D29625: Add global shortcut

2020-05-11 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:63a6340a711d: Add global shortcut (authored by Guo Yunhe 
i...@guoyunhe.me).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82532=82564

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma, mart
Cc: ngraham, davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 82532.
guoyunhe added a comment.


  Create symlink

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82515=82532

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread Yunhe Guo 
guoyunhe updated this revision to Diff 82515.
guoyunhe added a comment.


  Use KGlobalAccel instead

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29625?vs=82508=82515

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.desktop

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread David Redondo 
davidre added a comment.


  In D29625#668203 , @davidre wrote:
  
  > -1 for khotkeys.
  
  
  Add `X-KDE-Shortcuts`  to the desktop file instead and instal it to 
share/kglobalaccel

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread David Redondo 
davidre added a comment.


  -1 for khotkeys.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread Yunhe Guo 
guoyunhe added a comment.


  In D29625#668190 , @ognarb wrote:
  
  > I think khotkeys is deprecated: https://phabricator.kde.org/T2050
  
  
  Not yet, it is delayed to KF6.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread Carl Schwan 
ognarb added a comment.


  I think khotkeys is deprecated: https://phabricator.kde.org/T2050

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D29625

To: guoyunhe, #plasma
Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29625: Add global shortcut

2020-05-11 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  The "Tools" key is function key in some laptops. In ThinkPad + Windows, when 
you press that key, it will open Control Panel or Windows 10 Settings. But in 
Linux, it does nothing. So I think it can be a good shortcut for System 
Settings because no other software use it.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29625

AFFECTED FILES
  app/CMakeLists.txt
  app/systemsettings.khotkeys

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart