D29635: [kcms/keys] Make saving sync

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fcb04768142f: [kcms/keys] Make saving sync (authored by 
davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29635?vs=82535=82622

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29635: [kcms/keys] Make saving sync

2020-05-11 Thread David Redondo
davidre created this revision.
davidre added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  If it's async it will not save when changing modules, or quitting kcmshell, 
see T13140 .
  BUG: 421333

TEST PLAN
  Make a change, change module in systemsettings. Changes are saved.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  syncSave (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29635

AFFECTED FILES
  kcms/keys/shortcutsmodel.cpp

To: davidre, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart