D29781: Fix importing key-direction from *.ovpn files

2020-05-17 Thread Johan Ouwerkerk
ouwerkerk abandoned this revision.
ouwerkerk added a comment.


  With the move to gitlab/invent.kde.org it seems better to abandon this in 
favour of a straightforward MR using the new shiny :) 
  See: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/1

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29781

To: ouwerkerk, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29781: Fix importing key-direction from *.ovpn files

2020-05-15 Thread Johan Ouwerkerk
ouwerkerk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
ouwerkerk requested review of this revision.

REVISION SUMMARY
  It is possible for key-direction to be specified *after* .
  Previously the code always expected it to be defined before, with this
  change *.ovpn files that define it after should also be imported correctly.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  fix-ovpn-import-of-key-direction

REVISION DETAIL
  https://phabricator.kde.org/D29781

AFFECTED FILES
  vpn/openvpn/openvpn.cpp

To: ouwerkerk, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart