D29785: Always use Window colorset for AbstractApplicationHeader

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:5a716f3947dd: Always use Window colorset for 
AbstractApplicationHeader (authored by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29785?vs=82968&id=83040

REVISION DETAIL
  https://phabricator.kde.org/D29785

AFFECTED FILES
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D29785: Always use Window colorset for AbstractApplicationHeader

[Nathaniel Graham]

ngraham added a comment.


  Not all of the headers use toolbars, but I thought the idea was for them all 
to use a consistent base appearance? @mart?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29785

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D29785: Always use Window colorset for AbstractApplicationHeader

[Aleix Pol Gonzalez]

apol added a comment.


  I wonder if this should be specified in ToolBarApplicationHeader instead.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D29785

To: ngraham, #kirigami, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart

D29785: Always use Window colorset for AbstractApplicationHeader

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  ...Otherwise when an `AbstractApplicationHeader` is used on a page that
  overrides the color set, such as `ScrollablePage`, the header color is
  inappropriately set to the view BG color.
  
  BUG: 421573
  FIXED-IN; 5.71

TEST PLAN
  List view of Cards and Grid view of Cards in Kirigami gallery look
  correct now: F8323628: Screenshot_20200515_113715.png 


REPOSITORY
  R169 Kirigami

BRANCH
  always-use-window-colorset-for-application-header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29785

AFFECTED FILES
  src/styles/org.kde.desktop/AbstractApplicationHeader.qml

To: ngraham, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart