D29820: Correction when displaying "badger counter" icons using software rendering

[Nathaniel Graham]

ngraham commandeered this revision.
ngraham edited reviewers, added: brunogoncalves; removed: ngraham.
ngraham added a comment.


  This was done on GitLab, and was gated on hardware rendering being used.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: ngraham, brunogoncalves
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29820: Correction when displaying "badger counter" icons using software rendering

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> TaskBadgeOverlay.qml:47
>  sourceItem: icon
> -hideSource: true
> +hideSource: false
>  }

does this still renders correctly when used on hardware rendering? i suspect 
the cut away effect won't be visible?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: brunogoncalves, ngraham
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29820: Correction when displaying "badger counter" icons using software rendering

[Marco Martin]

mart added a comment.


  yes please on gitlab.
  are you sure you don't get double painting on opengl now?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: brunogoncalves, ngraham
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29820: Correction when displaying "badger counter" icons using software rendering

[Nathaniel Graham]

ngraham added a comment.


  We have moved to GitLab now; could you submit this as a Merge Request at 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests?
  
  Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

To: brunogoncalves, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29820: Correction when displaying "badger counter" icons using software rendering

[Bruno Gonçalves]

brunogoncalves created this revision.
brunogoncalves added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
brunogoncalves requested review of this revision.

REVISION SUMMARY
  Icons that use content overlay, leave the icon hidden when using software 
rendering.
  
  This small change corrects the problem and I did not notice any problems as a 
result.
  
  A simple test for this is to use the desktop telegram with the plasma in 
software rendering and taskbar in icon-only mode.
  
  Using OpenGL the icon is displayed and a counter with the number of messages 
appears overlapping part of the icon, all right.
  
  Using software rendering, the icon disappears when the counter is displayed.
  
  With this modification, the operation using software rendering is corrected.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29820

AFFECTED FILES
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml

To: brunogoncalves, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart