D4353: [Applet Configuration] Add mnemonics for dialog buttons
broulik abandoned this revision. broulik added a comment. Let's not hijack this review for a potential QQC2 port REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D4353: [Applet Configuration] Add mnemonics for dialog buttons
broulik planned changes to this revision. broulik added a comment. Just tried, porting it to QQC2 will give it auto mnemonics \o/ will look into that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D4353: [Applet Configuration] Add mnemonics for dialog buttons
broulik added a comment. I think the auto mnemonic stuff only affects QQC2? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D4353: [Applet Configuration] Add mnemonics for dialog buttons
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Is this the right approach given the auto mnemoics stuff Marco wrote which is merged now? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Differential] [Request, 6 lines] D4353: [Applet Configuration] Add mnemonics for dialog buttons
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Unfortunately due to the way Breeze style and QtQuick Controls 1 work you cannot see them unless you hold Alt and then hover the button to trigger an update. At least you can press Alt+O/C/A (or localized variants) now to okay/cancel/apply. TEST PLAN Dunno how to hint this to translators properly - in German "Abbrechen" would be A whereas "Anwenden" should become "N"... we don't get this automatism we have with widgets :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 AFFECTED FILES desktoppackage/contents/configuration/AppletConfiguration.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas