D4830: Adjust plasma-desktop to the new fallback prefixes

2017-12-18 Thread David Edmundson 
davidedmundson closed this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

To: davidedmundson, #plasma, broulik
Cc: obnosim, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4830: Adjust plasma-desktop to the new fallback prefixes

2017-12-15 Thread obnosim 
obnosim reopened this revision.
obnosim added a comment.
This revision is now accepted and ready to land.


  There is an issue in file desktoppackage/contents/views/Panel.qml line 57:
  
  Instead of
  
prefix = [prefix, ""];
  
  it should be
  
prefix = [pre, ""];
  
  otherwise (as is currently the case) the function adjustPrefix does nothing 
and panels always use un-prefixed theme elements.
  
  This has no visible impact on Breeze but it does on themes that do use 
prefixes in panel-background.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

To: davidedmundson, #plasma, broulik
Cc: obnosim, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4830: Adjust plasma-desktop to the new fallback prefixes

2017-03-20 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a521ac8f8882: Adjust plasma-desktop to the new fallback 
prefixes (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4830?vs=11967=12632

REVISION DETAIL
  https://phabricator.kde.org/D4830

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  desktoppackage/contents/views/Panel.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Accepted] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-03-01 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  When I move my panel around I get warnings
  
The image "widgets/tasks" doesn't contain any of the prefixes ("south-", "")
  
  but I think that is a false-positive.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-28 Thread David Edmundson 
davidedmundson updated this revision to Diff 11967.
davidedmundson added a comment.


  Proper handling of TaskProgressOverlay

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4830?vs=11958=11967

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4830

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  desktoppackage/contents/views/Panel.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Commented On] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-28 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> TaskProgressOverlay.qml:46
>  imagePath: "widgets/tasks"
> -prefix: calculatePrefix()
> -onRepaintNeeded: prefix = calculatePrefix()
> -
> -function calculatePrefix() {
> -var prefix = TaskTools.taskPrefix("progress")
> -if (!frame.hasElementPrefix(prefix)) {
> -prefix = TaskTools.taskPrefix("hover")
> -}
> -return prefix
> -}
> +prefix: [TaskTools.taskPrefix("progress"), 
> TaskTools.taskPrefix("hover")]
>  }

Now you place an array inside of an array.

(btw knotifications has a unitylauncher test app where you can test this, e.g. 
`~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin 
--progress 50`)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-28 Thread David Edmundson 
davidedmundson marked an inline comment as done.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Updated, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-28 Thread David Edmundson 
davidedmundson updated this revision to Diff 11958.
davidedmundson added a comment.


  Fixed a stupid mistake

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4830?vs=11911=11958

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4830

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  desktoppackage/contents/views/Panel.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Changed Subscribers] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-28 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> TaskProgressOverlay.qml:46
>  imagePath: "widgets/tasks"
> -prefix: calculatePrefix()
> -onRepaintNeeded: prefix = calculatePrefix()
> -
> -function calculatePrefix() {
> -var prefix = TaskTools.taskPrefix("progress")
> -if (!frame.hasElementPrefix(prefix)) {
> -prefix = TaskTools.taskPrefix("hover")
> -}
> -return prefix
> -}
> +prefix: ["progress", "hover"]
>  }

You don't take into account orientation here (south/north/west/...) which 
`TaskTools.taskPrefix` does

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

[Differential] [Request, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

2017-02-27 Thread David Edmundson 
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Grepped code for repaintNeeded on prefixes and adjusted as appropriately to 
match
  https://phabricator.kde.org/D4827

TEST PLAN
  Booted, looks the same.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4830

AFFECTED FILES
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  desktoppackage/contents/views/Panel.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol