D5012: Delay notifications until desktop session has loaded
davidedmundson added a comment. Fix in https://phabricator.kde.org/D5968 > Undefined means anything can happen That is what the word means, but DBus isn't a black box. We do roughly know what it will do. If it was truly problematic, they would force the name to match, something which is enforced on the system bus. > More info "transient service activation" is the googlable name. https://bugs.freedesktop.org/show_bug.cgi?id=99825 It's in 1.11.12. Which I think isn't used by anyone yet REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: fvogt, lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5012: Delay notifications until desktop session has loaded
fvogt added a comment. In https://phabricator.kde.org/D5012#111492, @davidedmundson wrote: > Sure, but the current state of having two notification systems was already undefined long before this patch. Two notification systems? That's not the case here as far as I can tell. > Undefined trumps not being a defined state of not co-installable in this case. Undefined means anything can happen and thus it's worse than not being co-installable. In our packaging we can simply make the file an optional (but recommended) dep, which means the user can choose between this fix and co-installability with other DEs. > There is a long term fix where service files will also go into /run/user this will solve all our problems. That's not out yet though. Generating a set of services at runtime? Sounds interesting, where can I get some more information about that from? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: fvogt, lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5012: Delay notifications until desktop session has loaded
davidedmundson added a comment. Sure, but the current state of having two notification systems was already undefined long before this patch. Undefined trumps not being a defined state of not co-installable in this case. There is a long term fix where service files will also go into /run/user this will solve all our problems. That's not out yet though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: fvogt, lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5012: Delay notifications until desktop session has loaded
fvogt added a comment. In https://phabricator.kde.org/D5012#111331, @davidedmundson wrote: > There's no need for the .service file to match the dbus service name > > We change that, we get no file colision. > I wrote a patch on Friday when someone told me on irc, but hadn't tested because I had to rebuild something. > I'm back tomorrow, will upload then. This is not a real fix. Quoting the specification (https://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-starting-services): > On the well-known session bus, if two .service files in the same directory offer the same service name, the result is undefined. Distributors should avoid this situation, for instance by naming session services' .service files according to their service name. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: fvogt, lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5012: Delay notifications until desktop session has loaded
davidedmundson added a comment. There's no need for the .service file to match the dbus service name We change that, we get no file colision. I wrote a patch on Friday when someone told me on irc, but hadn't tested because I had to rebuild something. I'm back tomorrow, will upload then. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5012: Delay notifications until desktop session has loaded
vpilo added a comment. In https://phabricator.kde.org/D5012#110815, @lbeltrame wrote: > Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch. I wouldn't know what course of action would be best to follow in this case. @davidedmundson ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5012: Delay notifications until desktop session has loaded
lbeltrame added a comment. Months later, it turns out that notify-osd ships a org.freedesktop.Notifications.service already, so it conflicts with the one made by this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma_workspaces, #plasma, davidedmundson, mck182, broulik, dfaure, graesslin Cc: lbeltrame, graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5012: Delay notifications until desktop session has loaded
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bf889f7b94b: Add program to wait for D-Bus Notifications services to register. (authored by vpilo). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5012?vs=12378=12609#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5012?vs=12378=12609 REVISION DETAIL https://phabricator.kde.org/D5012 AFFECTED FILES startkde/CMakeLists.txt startkde/waitforname/CMakeLists.txt startkde/waitforname/main.cpp startkde/waitforname/org.freedesktop.Notifications.service.in startkde/waitforname/waiter.cpp startkde/waitforname/waiter.h To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, broulik, mck182 Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5012: Delay notifications until desktop session has loaded
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, broulik, mck182 Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5012: Delay notifications until desktop session has loaded
vpilo added reviewers: graesslin, dfaure, davidedmundson, broulik, mck182. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces, graesslin, dfaure, davidedmundson, broulik, mck182 Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5012: Delay notifications until desktop session has loaded
vpilo added reviewers: Plasma, Plasma: Workspaces. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo, #plasma, #plasma_workspaces Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5012: Delay notifications until desktop session has loaded
vpilo added a dependency: D4799: Delay notifications until desktop session has loaded. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 To: vpilo Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5012: Delay notifications until desktop session has loaded
vpilo created this revision. vpilo added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Added program to wait for D-Bus Notifications services to register. Needed for Plasma to delay showing notifications until the desktop has fully loaded. Related change: https://phabricator.kde.org/D4799 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5012 AFFECTED FILES startkde/CMakeLists.txt startkde/waitforname/CMakeLists.txt startkde/waitforname/main.cpp startkde/waitforname/org.freedesktop.Notifications.service.in startkde/waitforname/waiter.cpp startkde/waitforname/waiter.h To: vpilo Cc: graesslin, dfaure, davidedmundson, broulik, mck182, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
