D5209: Load translations from KPackage files if bundled
ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D5209: Load translations from KPackage files if bundled
avaragic added a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D5209: Load translations from KPackage files if bundled
ltoscano added a comment. In https://phabricator.kde.org/D5209#124129, @davidedmundson wrote: > contents/locale/fr/org.kde.blahblah.po > > which is the same as KDE4. I guess you mean contents/locale/fr/org.kde.blahblah.**mo** ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5209: Load translations from KPackage files if bundled
davidedmundson added a comment. contents/locale/fr/org.kde.blahblah.po which is the same as KDE4. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5209: Load translations from KPackage files if bundled
Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2. `digitalclock.plasmoid/contents/translations/plasma_applet_org.kde.plasma.digitalclock.po` 3. `digitalclock.plasmoid/translations/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.po` 4. `digitalclock.plasmoid/contents/translations/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.po` So adding the domain will load `.po` files too? Or do they need to be `.mo` files? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5209: Load translations from KPackage files if bundled
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a0f61b5591d: Load translations from KPackage files if bundled (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5209?vs=12891=16510 REVISION DETAIL https://phabricator.kde.org/D5209 AFFECTED FILES src/plasma/pluginloader.cpp To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5209: Load translations from KPackage files if bundled
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D5209: Load translations from KPackage files if bundled
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Installed battery monitor locally with kpackagetool5 -i moved x-test .po file from being installed systemwide to only being inside the bundle still get xx everywhere REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5209 AFFECTED FILES src/plasma/pluginloader.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol