D5868: make pagerow test pass

2017-05-19 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f59205a8f467: make pagerow test pass (authored by mart).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5868?vs=14554=14685

REVISION DETAIL
  https://phabricator.kde.org/D5868

AFFECTED FILES
  src/controls/PageRow.qml

To: mart, #kirigami, apol
Cc: plasma-devel, apol

D5868: make pagerow test pass

2017-05-18 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Tested, it's definitely better.

REPOSITORY
  R169 Kirigami

BRANCH
  phab/pagerowtest

REVISION DETAIL
  https://phabricator.kde.org/D5868

To: mart, #kirigami, apol
Cc: plasma-devel, apol

D5868: make pagerow test pass

2017-05-15 Thread Marco Martin 
mart created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  during the pop animation the actual depth differs from the stored one
  as the pages that are being popped are still in the data structure
  so they have to not be considered for the public depth property

TEST PLAN
  gallery still works, autotests work

REPOSITORY
  R169 Kirigami

BRANCH
  phab/pagerowtest

REVISION DETAIL
  https://phabricator.kde.org/D5868

AFFECTED FILES
  src/controls/PageRow.qml

To: mart, #kirigami, apol
Cc: plasma-devel, apol