D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
hein added a comment. I actually set you as reviewer on that one via arc, but somehow it dropped all subscribers, fuck. Sorry about the unnecessary work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
hein added a comment. Duplicate of https://phabricator.kde.org/D7567. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
broulik updated this revision to Diff 18880. broulik added a comment. Slight cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7583?vs=18879=18880 REVISION DETAIL https://phabricator.kde.org/D7583 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/kicker/plugin/actionlist.h applets/kicker/plugin/appentry.cpp applets/kicker/plugin/appentry.h applets/kicker/plugin/menuentryeditor.cpp applets/kicker/plugin/menuentryeditor.h applets/kicker/plugin/runnermatchesmodel.cpp To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7583: [Kicker] Add "Edit application" and "Manage application" entry to service runner results
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes application search results consistent with applications in the menu. The ifdef'd AppStream logic is completely moved into the Kicker namespace and MenuEntryEditor is turned into a proper singleton. BUG: 384036 FIXED-IN: 5.11.0 TEST PLAN - Edit Application and Manage %1 is still properly shown for applications. Separators look sane with either or both of them shown. - The entries are properly shown and functional now on service runner application results REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7583 AFFECTED FILES applets/kicker/plugin/actionlist.cpp applets/kicker/plugin/actionlist.h applets/kicker/plugin/appentry.cpp applets/kicker/plugin/appentry.h applets/kicker/plugin/menuentryeditor.cpp applets/kicker/plugin/menuentryeditor.h applets/kicker/plugin/runnermatchesmodel.cpp To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
