D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

romangg abandoned this revision.
romangg added a comment.


  Has been made unnecessary by 1e218b405bee 
.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: romangg, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Nathaniel Graham]

ngraham added a comment.


  Thanks. I only bring this up because it's currently listed as a blocker for 
https://phabricator.kde.org/D7769, which as been accepted and was mentioned as 
a solution for a Task Manager bug (I'm screening all of them today).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: romangg, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

romangg added a comment.


  Thanks for the reminder. I have to understand the problem better first I 
believe. The others are right that my proposed solution is rather poor. As I 
said if somebody else can help me out here, this would be great. Otherwise I'll 
try to dissect the issue myself when I have time for it again (which could be 
after the release of 5.12). Since it's only a small glitch, it has low priority 
for me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: romangg, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: romangg, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Nathaniel Graham]

ngraham added a comment.


  What's next for this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: ngraham, hein, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

subdiff added a comment.


  In https://phabricator.kde.org/D7768#145079, @davidedmundson wrote:
  
  > So now you copy to the data of toolTipDelegate.parentTask when the mouse 
leaves? 
  >  Why does that help?
  
  
  Good question. I don't understand how it helps, but it does. Somehow the 
model data needs to be copied an additional time to the delegate. It's 
something deeper probably, because without this patch (and only my other one) I 
even get seg faults when after I do manually change the task order I quickly 
raise another tooltip.
  
  If you find a better solution, come forward. Otherwise I could also add a 
comment in the code explaining why we always copy the data.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: hein, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Eike Hein]

hein added a comment.


  Yeah this one looks odd to me too as per David ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: hein, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[David Edmundson]

davidedmundson added a comment.


  So now you copy to the data of toolTipDelegate.parentTask when the mouse 
leaves? 
  Why does that help?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

subdiff added a dependent revision: D7769: [Task Manager] Use Grid for grouped 
and single tooltips.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

subdiff edited the summary of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

To: subdiff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7768: [Task Manager] On containsMouse change always reset toolTipDelegate data

[Roman Gilg]

subdiff created this revision.
subdiff added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Manually moving grouped tool tips together with single ones could mess up the 
mapping of their data. This patch makes sure that the correct information is 
provided by forcing reset of data on every containsMouse change.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7768

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: subdiff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart