D7846: [tabbox] Drop the passing to Effects in X11 Filter

2017-09-30 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f7d6e4affd22: [tabbox] Drop the passing to Effects in X11 
Filter (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7846?vs=19581=20138

REVISION DETAIL
  https://phabricator.kde.org/D7846

AFFECTED FILES
  effects.cpp
  effects.h
  tabbox/x11_filter.cpp
  tabbox/x11_filter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7846: [tabbox] Drop the passing to Effects in X11 Filter

2017-09-24 Thread Martin Flöser 
graesslin added a comment.


  ping

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7846

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7846: [tabbox] Drop the passing to Effects in X11 Filter

2017-09-23 Thread Martin Flöser 
graesslin added a dependent revision: D7955: Move X11-only specific part of 
EffectsHandlerImpl to x11 platform plugin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7846

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D7846: [tabbox] Drop the passing to Effects in X11 Filter

2017-09-16 Thread Martin Flöser 
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  If an Effect has replaced the TabBox and wants to react on mouse events
  the EffectsHandlerImpl also has an X11Filter, so we only need to make
  sure the events go to that filter.
  
  Motion: TabBox did not filter out, so events will go to the Effects
  filter.
  Press/Release: TabBox should not operate if Effects take the events.
  The events are filtered out by Effects if there is a grab, so just
  check for that and go out. Effects will take care.

TEST PLAN
  Compiles

REPOSITORY
  R108 KWin

BRANCH
  tabbox-no-effects-in-filter

REVISION DETAIL
  https://phabricator.kde.org/D7846

AFFECTED FILES
  effects.cpp
  effects.h
  tabbox/x11_filter.cpp
  tabbox/x11_filter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart