D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas abandoned this revision. arojas added a comment. Superseded by https://phabricator.kde.org/D7953 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas added a comment. Opened https://phabricator.kde.org/D7953 for the QQuickStyle approach. Keeping this open in case the new dependency is not acceptable for 5.11 at this stage. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas added a comment.
Indeed, replacing the qputenv line with
QQuickStyle::setStyle(QLatin1String("org.kde.desktop")) fixes the inheritance
problem: minuet doesn't crash anymore and systemsettings is correctly themed.
Unfortunately QQC1 (such as kalgebramobile) still crash, is there something
equivalent for QQC1?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D7943
To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
davidedmundson added a comment. Edit: given were doing this in c++in process, maybe can we just call https://doc.qt.io/qt-5/qquickstyle.html#setStyle Instead of messing about with environment variables? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
davidedmundson added a comment. We shouldn't. It doesn't gain us anything. More importantly, the one thing this patch doesn't cover is apps that don't have desktopSettingsAware set as they'll never load the qpt. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas added a comment. In https://phabricator.kde.org/D7943#148121, @davidedmundson wrote: > Revert what? The move of the style setting from startkde to plasma-integration REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
davidedmundson added a comment. Revert what? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas added a comment. This change would also fix the crashes if the style was set in startkde as it used to, does it make sense to revert the change or you prefer to leave it where it is? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I see, shame we're not still using kinit. Patch makes sense. Thanks REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas added a comment. In https://phabricator.kde.org/D7943#148093, @davidedmundson wrote: > I don't see why we should be unsetting anything if a user has explicitly gone out of their way to set it. > > We're not doing it from startkde anymore. It's not the user who sets it, it's plasmashell. See my last comment in bug 384481 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see why we should be unsetting anything if a user has explicitly gone out of their way to set it. We're not doing it from startkde anymore. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D7943: Explicitely unset QtQuickControls desktop style for non-QApplications
arojas created this revision. arojas added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QGuiApplications will crash if the QtQuickControls style (either 1 or 2) is set to desktop, so make sure to unset it in that case. TEST PLAN Login to Plasma session, make sure that QT_QUICK_CONTROLS_STYLE=org.kde.desktop and QT_QUICK_CONTROLS_1_STYLE=/whatever/Desktop, check that Minuet, KAlgebra Mobile and the mapviewer example from QtLocation run correctly and don't crash anymore REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D7943 AFFECTED FILES src/platformtheme/kdeplatformtheme.cpp To: arojas, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
