D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler 
Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:7491ed93c8cb: Support domain-suffix-match in 
Security8021xSetting (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21153=21220

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  autotests/settings/8021xsettingtest.cpp
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler 
Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Jan Grulich 
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Good to go. Thank you.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Marius Kittler 
Martchus updated this revision to Diff 21153.
Martchus added a comment.


  Add "domainSuffixMatch" to auto tests

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21149=21153

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  autotests/settings/8021xsettingtest.cpp
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Jan Grulich 
jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.


  Now it looks good. Just one thing I forgot is a unit test for this property. 
You can add it to autotests/settings/8021xsettingtest.cpp and build the tests 
with "-DBUILD_TESTING=true" cmake command and then running "make tests" to 
verify your test passes.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-23 Thread Marius Kittler 
Martchus updated this revision to Diff 21149.
Martchus added a comment.


  Changed the method names

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21069=21149

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-22 Thread Jan Grulich 
jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> security8021xsetting.h:66
>  
> +void setDomain(const QString );
> +QString domain() const;

Usually these methods are named according to property they return so in this 
case it should be setDomainSuffixMatch() and domainSuffixMatch().  Same applies 
to other places where you use just domain.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler 
Martchus edited the test plan for this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler 
Martchus added a dependency: D8405: Allow to set "domain-suffix-match" in Wi-Fi 
settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-21 Thread Marius Kittler 
Martchus created this revision.
Martchus added a reviewer: Plasma.
Martchus added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Required for 'Allow setting "domain-suffix-match" in Wi-Fi settings' in 
plasma-nm which concerns Wi-Fi settings of enterprise WPA/WPA2:
  
  - TLS
  - tunneled TLS
  - PEAP

TEST PLAN
  1. Apply 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm 
as well
  2. Open connection settings
  3. Select Wi-Fi connection
  4. Configure domain under enterprise security settings
  5. Apply
  6. Open related config file, eg. 
`/etc/NetworkManager/system-connections/eduroam`
  7. Check whether "domain-suffix-match" is set correctly.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart