D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel 
mlaurent marked an inline comment as done.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel 
mlaurent updated this revision to Diff 21288.
mlaurent added a comment.


  - Don't use Q_FOREACH as it will be deprecated in the future

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8444?vs=21283&id=21288

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Martin Flöser 
graesslin added inline comments.

INLINE COMMENTS

> generator.cpp:550
> +
> +Q_FOREACH(KScreen::OutputPtr output, connectedOutputs) {
> +output->setEnabled(true);

Please don't use qforeach in new code as Qt might deprecate it.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-25 Thread Laurent Montel 
mlaurent updated this revision to Diff 21283.
mlaurent added a comment.


  - Update extend to left

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8444?vs=21231&id=21283

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel 
mlaurent added a subscriber: dvratil.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread David Edmundson 
davidedmundson added a comment.


  Unless I'm misreading things, I think there's one part that's going to appear 
very confusing.
  
  I have my (small) laptop. Lets say I want any new (big) screen to appear on 
the left. So I save "Extend to left".
  So I'd expect to see: monitor, laptop.
  
  What will happen, is it will extend my biggest screen to the left, leaving me 
with:
  laptop, monitor
  
  rendering the option seemingly broken.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel 
mlaurent added a comment.


  Wierd why it created a new review ???
  This one is more recent.
  I will close 8442

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Nathaniel Graham 
ngraham added a comment.


  Looks like this was opened by mistake; you've already got 
https://phabricator.kde.org/D8442. Can this be closed?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D8444

To: mlaurent
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8444: WIP: Define default Action when we plug unknown monitor

2017-10-24 Thread Laurent Montel 
mlaurent created this revision.
mlaurent added a project: Plasma.

REVISION SUMMARY
  Default action when we plug unknown monitor

REPOSITORY
  R104 KScreen

BRANCH
  customize_connect_unknown_monitor

REVISION DETAIL
  https://phabricator.kde.org/D8444

AFFECTED FILES
  kcm/src/kcm_kscreen.cpp
  kcm/src/widget.cpp
  kcm/src/widget.h
  kded/generator.cpp
  kded/generator.h
  tests/kded/CMakeLists.txt

To: mlaurent
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart