D8578: [platforms/drm] Forward the mode changes to the OutputInterface
This revision was automatically updated to reflect the committed changes. Closed by commit R108:59f7ed9c780a: [platforms/drm] Forward the mode changes to the OutputInterface (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8578?vs=21660=22088 REVISION DETAIL https://phabricator.kde.org/D8578 AFFECTED FILES plugins/platforms/drm/drm_output.cpp To: graesslin, #kwin, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8578: [platforms/drm] Forward the mode changes to the OutputInterface
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drm-mode-to-output REVISION DETAIL https://phabricator.kde.org/D8578 To: graesslin, #kwin, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8578: [platforms/drm] Forward the mode changes to the OutputInterface
graesslin added a dependent revision: D8602: [platforms/drm] Restore previous mode if an atomic test fails. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8578 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8578: [platforms/drm] Forward the mode changes to the OutputInterface
graesslin updated this revision to Diff 21660. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Add guard REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8578?vs=21654=21660 BRANCH drm-mode-to-output REVISION DETAIL https://phabricator.kde.org/D8578 AFFECTED FILES plugins/platforms/drm/drm_output.cpp To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8578: [platforms/drm] Forward the mode changes to the OutputInterface
davidedmundson added inline comments.
INLINE COMMENTS
> drm_output.cpp:214
> setDpms(DpmsMode::On);
> if (!m_waylandOutput.isNull()) {
> delete m_waylandOutput.data();
This method is coded so that init() can be called twice.
Either:
- that's pointless, and this should just be an assert that m_waylandOutput is
null.
- we need to make sure we don't do a double connect
(either through disconnecting or just putting the
m_waylandOutput->setCurrentMode() call in ::updateMode
> drm_output.cpp:221
> +[this] {
> +m_waylandOutput->setCurrentMode(QSize(m_mode.hdisplay,
> m_mode.vdisplay), refreshRateForMode(_mode));
> +}
Every other setFooBar guards m_waylandOutput.
It seems currently superfuous, but as soon as we code up enabledChanged to work
it'll be needed.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8578
To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8578: [platforms/drm] Forward the mode changes to the OutputInterface
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY While KWin gained support for changing modes it did not yet forward it to the Wayland OutputInterface. This change implements this missing todo by finding the matching mode and marking it as current. TEST PLAN Run kinfocenter to verify the current mode is properly set. REPOSITORY R108 KWin BRANCH drm-mode-to-output REVISION DETAIL https://phabricator.kde.org/D8578 AFFECTED FILES plugins/platforms/drm/drm_output.cpp To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
