D9131: [comic] Destroy download dialog as time of applet

2017-12-06 Thread Anthony Fieroni 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:19784bfc4b9c: [comic] Make sure KNS download dialog is 
destroyed (authored by anthonyfieroni).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9131?vs=23461=23581

REVISION DETAIL
  https://phabricator.kde.org/D9131

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-04 Thread Anthony Fieroni 
anthonyfieroni updated this revision to Diff 23461.
anthonyfieroni added a comment.


  Ability to detect delete on close.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9131?vs=23457=23461

REVISION DETAIL
  https://phabricator.kde.org/D9131

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-04 Thread Anthony Fieroni 
anthonyfieroni updated this revision to Diff 23457.
anthonyfieroni added a comment.


  Oh i revert patch, DownloadDialog expect Widget as its parent.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9131?vs=23413=23457

REVISION DETAIL
  https://phabricator.kde.org/D9131

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-04 Thread Anthony Fieroni 
anthonyfieroni updated this revision to Diff 23413.
anthonyfieroni added a comment.


  Take ownership of DownloadDialog.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9131?vs=23339=23413

REVISION DETAIL
  https://phabricator.kde.org/D9131

AFFECTED FILES
  applets/comic/comic.cpp

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-04 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Personally I'd have just set a parent when creating the new 
KNS3::DownloadDialog.
  
  If someone ever did change this code so it deletes on close, the old code 
would have handled it, this won't.
  
  But this is also fine.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9131

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-04 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  It's called only from here -> 
https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/comic/package/contents/ui/configGeneral.qml$91

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9131

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-03 Thread Aleix Pol Gonzalez 
apol added a comment.


  QScopedPointer won't be checking if the object has been destroyed. Are you 
sure it will never happen?
  If so, +1.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9131

To: anthonyfieroni, davidedmundson, broulik
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D9131: [comic] Destroy download dialog as time of applet

2017-12-03 Thread Anthony Fieroni 
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  When DownloadDialog is not destroyed KNS3 engine not store registry of 
installed/upgradable stuff.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9131

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: anthonyfieroni, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart