D9479: [widgetexplorer] Fix trying to show deleted dialog

2017-12-22 Thread Anthony Fieroni 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:acd7034952bc: [widgetexplorer] Fix trying to show deleted 
dialog (authored by anthonyfieroni).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9479?vs=24297=24298

REVISION DETAIL
  https://phabricator.kde.org/D9479

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

To: anthonyfieroni, fvogt, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9479: [widgetexplorer] Fix trying to show deleted dialog

2017-12-22 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9479

To: anthonyfieroni, fvogt, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9479: [widgetexplorer] Fix trying to show deleted dialog

2017-12-22 Thread Anthony Fieroni 
anthonyfieroni updated this revision to Diff 24297.
anthonyfieroni added a comment.


  Remove entire destructor.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9479?vs=24296=24297

REVISION DETAIL
  https://phabricator.kde.org/D9479

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

To: anthonyfieroni, fvogt, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9479: [widgetexplorer] Fix trying to show deleted dialog

2017-12-22 Thread Fabian Vogt 
fvogt added a comment.


  IMO you can delete the empty destructor now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9479

To: anthonyfieroni, fvogt, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9479: [widgetexplorer] Fix trying to show deleted dialog

2017-12-22 Thread Anthony Fieroni 
anthonyfieroni created this revision.
anthonyfieroni added reviewers: fvogt, davidedmundson, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  WidgetExplorer is destroyed on close which deletes KNS dialog.

TEST PLAN
  Manually test, verify it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9479

AFFECTED FILES
  components/shellprivate/widgetexplorer/widgetexplorer.cpp

To: anthonyfieroni, fvogt, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart