Re: Loading RunCommand.qml file in KRunner using QRC

2022-08-28 Thread Nate Graham
+1, I think this makes sense. Allowing Plasma themes to include code has 
always been fragile and dangerous, and anything that incrementally moves 
us away from that is a good thing IMO.


Nate



On 8/27/22 13:53, alexander.loh...@gmx.de wrote:

Hello everyone,
  
I write this mail regarding the proposed change of https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032.

Currently we load the main KRunner QML file “RunCommand.qml” from the look and 
feel KPackage. However, this has caused issues repeatedly in the past, because 
old/broken QML files can be loaded.
The idea from the beginning of Plasma 5 seemed to be that the design of Krunner 
should be changeable with the theme, however most of the code in this file is 
application logic.

The only issue is that the LNF mechanism is considered public API. Thus this 
change is considered controversial.
Merging it would mean that potential RunCommand.qml files from the LNF packages 
are just ignored. IMHO that is no problem.
  
Any thoughts?
  
Regards

Alexander


Loading RunCommand.qml file in KRunner using QRC

2022-08-27 Thread Alexander . Lohnau
Hello everyone,
 
I write this mail regarding the proposed change of 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2032.
Currently we load the main KRunner QML file “RunCommand.qml” from the look and 
feel KPackage. However, this has caused issues repeatedly in the past, because 
old/broken QML files can be loaded.
The idea from the beginning of Plasma 5 seemed to be that the design of Krunner 
should be changeable with the theme, however most of the code in this file is 
application logic.

The only issue is that the LNF mechanism is considered public API. Thus this 
change is considered controversial.
Merging it would mean that potential RunCommand.qml files from the LNF packages 
are just ignored. IMHO that is no problem.
 
Any thoughts?
 
Regards
Alexander