Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
oops, forgot to hit the publish button, should be up now http://reviewboard.kde.org/r/1248/ On Sun, Aug 9, 2009 at 3:00 PM, Patrick Aljord wrote: > http://reviewboard.kde.org/r/1248/ here is the diff with the > imagebinPrivacy always as int. > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
http://reviewboard.kde.org/r/1248/ here is the diff with the imagebinPrivacy always as int. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 9, 2009 12:42:30 Patrick Aljord wrote: > On Sat, Aug 8, 2009 at 1:56 PM, Chani wrote: > > kompare won't load the diff for some reason... > > I used the techbase tutorial here > http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patc >h and used that command: > > svn diff --diff-cmd diff --extensions "-u -p" huh. I just use svn diff. :) it's possible the problem was with trying to load a file from kmail, and not with the diff itself. -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Sat, Aug 8, 2009 at 1:56 PM, Chani wrote: > > kompare won't load the diff for some reason... I used the techbase tutorial here http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patch and used that command: svn diff --diff-cmd diff --extensions "-u -p" ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
I was thinking with time we could add more options for alll the different servers, then a new page would make sense, for now it's true that it looks empty. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 8, 2009 18:41:32 Patrick Aljord wrote: > Thanks to all for your comments. I haven't coded anything in C++ for > at least 3 years so I guess it shows :) > > I'll send the patch with your suggestions tomorrow, in the meantime > here is the screenshot http://imagebin.ca/view/fyaoR7T.html hmmm. I don't think we need a separate page for that option. there's not much on the first page, after all. actually I'm not too keen on the existing "servers" page either. a very odd way to allow people to use other servers... I wonder why it was done that way... -- This message brought to you by eevil bananas and the number 3. www.chani3.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
Thanks to all for your comments. I haven't coded anything in C++ for at least 3 years so I guess it shows :) I'll send the patch with your suggestions tomorrow, in the meantime here is the screenshot http://imagebin.ca/view/fyaoR7T.html ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Saturday 08 August 2009, 16:35 Chani wrote: > oh. > but we also have this: > int imagebinPrivacy = uiServersOptions.imagebinPrivacy->currentIndex(); > > so, either make it always an int, or make it an enum. don't use a string. > especially a string that just contains a number anyways... +1 for always int -- Artur Duque de Souza openBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
> > one thing I don't get is how you managed to use a string ("0") as the
> > default value for an int ;)
>
> +QString m_privacy;
>
> m_privacy seems to be a QString :)
oh.
but we also have this:
int imagebinPrivacy = uiServersOptions.imagebinPrivacy->currentIndex();
so, either make it always an int, or make it an enum. don't use a string.
especially a string that just contains a number anyways...
--
This message brought to you by eevil bananas and the number 3.
www.chani3.com
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On Saturday 08 August 2009, 13:40 Patrick Aljord wrote:
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
Thanks for the patch! As Chani asked, can you provide a screenshot of the
config
dialog ?
Some comments on code:
Index: applets/pastebin/backends/imagebinca.h
===
--- applets/pastebin/backends/imagebinca.h (revision 1008583)
+++ applets/pastebin/backends/imagebinca.h (working copy)
@@ -42,6 +42,8 @@ public:
void finish();
bool addPair(const QString& name, const QString& value);
bool addFile(const QString& name,const QString& path);
+QString adult;
It seems that you do not need to store this string in the object and can
declare it when you setup this string, something like this:
QString adult;
+if(m_privacy == "0"){
+ adult = "f";
+} else {
+ adult = "t";
+}
> one thing I don't get is how you managed to use a string ("0") as the default
> value for an int ;)
+QString m_privacy;
m_privacy seems to be a QString :)
Cheers!
--
Artur Duque de Souza
openBossa Research Labs
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid
On August 8, 2009 09:40:28 Patrick Aljord wrote:
> Hey all,
>
> This is my first patch, it just adds "posting private picture to
> imagebin.ca from the pastebin plasmoid" as the title says, it needs to
> be applied from kdeplasma-addons, hope it works for you.
>
> Cheers,
>
> Pat
thanks for the patch :)
the code looks generally ok, although kompare won't load the diff for some
reason...
one thing I don't get is how you managed to use a string ("0") as the default
value for an int ;)
can you give us a screenshot of the new config?
btw, next time put your patch on reviewboard.kde.org, less chance of us losing
it there :)
--
This message brought to you by eevil bananas and the number 3.
www.chani3.com
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
