Re: Renaming appdata and desktop file for GCompris

2019-07-29 Thread Johnny Jazeix
Hi,

thanks for the explanation. We'll go with the
QGuiApplication::setDesktopFileName solution as we don't use KF5 and
it seems the easiest way to do it.

Johnny

Le lun. 29 juil. 2019 à 08:03, Harald Sitter  a écrit :
>
> Hi,
>
> Do note that the appstream file name  and the desktop file name do not
> need to be the same. An appstream file tags a specific desktop file as
>  [1]. So technically you do not need to rename it, you only
> need to change the desktop file and the provides entry. If you want to
> rename it do note that the  tag may contain an  tag,
> that's where you specify your old name and the appstream tooling will
> know that your component has two names.
>
> Lastly, I *think* you do not technically need to rename anything. If
> you want you should also be able to use KAboutData::setDesktopFileName
> [2] respectively QGuiApplication::setDesktopFileName [3] to help the
> task manager resolve the desktop file from your process without having
> to rename anything.
>
> [1] 
> https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
> [2] 
> https://api.kde.org/frameworks/kcoreaddons/html/classKAboutData.html#a112d2fc20c31e7847995930e030cc67b
> [3] https://doc.qt.io/qt-5/qguiapplication.html#desktopFileName-prop
>
> HS
>
> On Mon, Jul 29, 2019 at 12:02 AM Johnny Jazeix  wrote:
> >
> > Hi Plasma team,
> >
> > I'm a developer of GCompris and we recently had an issue with our
> > desktop file (https://bugs.kde.org/show_bug.cgi?id=409996).
> > Luigi proposed to ask you to know if changing the name of it would be
> > an issue or have some unseen consequences for application managers?
> >
> > I'm not subscribed to the list, please keep me in cc if you reply.
> >
> > Johnny
> >
> > -- Forwarded message -
> > De : Luigi Toscano 
> > Date: dim. 28 juil. 2019 à 14:29
> > Subject: Re: Renaming appdata and desktop file
> > To: KDE i18n-doc , Johnny Jazeix 
> >
> >
> > Johnny Jazeix ha scritto:
> > > Hi,
> > > for GCompris we named the files org.kde.gcompris.appdata.xml and
> > > org.kde.gcompris.desktop.
> > > However, our binary file is gcompris-qt. According to
> > > https://bugs.kde.org/show_bug.cgi?id=409996 (gcompris 0.96 has Wayland
> > > generic icon when you press alt+tab) and after some research
> > > (http://plfiorini.blogspot.com/2015/07/how-to-make-your-qt-application-icon.html),
> > > it seems we should rename our desktop file to
> > > org.kde.gcompris-qt.desktop
> > >
> > > Does changing the name is the good solution?
> >
> > I don't really have an answer for this. I would suggest asking the Plasma 
> > team
> > for confirmation. They probably know also whether renaming has can make
> > application managers think that this is a new program.
> >
> > > And if yes, do I just
> > > have to change the filenames (for both) and the translation can be
> > > automatically retrieved (or will I have to do some svn move)?
> >
> > A manual rename would be needed for the templates and the files, but I can
> > help with that.
> >
> > Ciao
> > --
> > Luigi


Re: Renaming appdata and desktop file for GCompris

2019-07-28 Thread Harald Sitter
Hi,

Do note that the appstream file name  and the desktop file name do not
need to be the same. An appstream file tags a specific desktop file as
 [1]. So technically you do not need to rename it, you only
need to change the desktop file and the provides entry. If you want to
rename it do note that the  tag may contain an  tag,
that's where you specify your old name and the appstream tooling will
know that your component has two names.

Lastly, I *think* you do not technically need to rename anything. If
you want you should also be able to use KAboutData::setDesktopFileName
[2] respectively QGuiApplication::setDesktopFileName [3] to help the
task manager resolve the desktop file from your process without having
to rename anything.

[1] 
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent
[2] 
https://api.kde.org/frameworks/kcoreaddons/html/classKAboutData.html#a112d2fc20c31e7847995930e030cc67b
[3] https://doc.qt.io/qt-5/qguiapplication.html#desktopFileName-prop

HS

On Mon, Jul 29, 2019 at 12:02 AM Johnny Jazeix  wrote:
>
> Hi Plasma team,
>
> I'm a developer of GCompris and we recently had an issue with our
> desktop file (https://bugs.kde.org/show_bug.cgi?id=409996).
> Luigi proposed to ask you to know if changing the name of it would be
> an issue or have some unseen consequences for application managers?
>
> I'm not subscribed to the list, please keep me in cc if you reply.
>
> Johnny
>
> -- Forwarded message -
> De : Luigi Toscano 
> Date: dim. 28 juil. 2019 à 14:29
> Subject: Re: Renaming appdata and desktop file
> To: KDE i18n-doc , Johnny Jazeix 
>
>
> Johnny Jazeix ha scritto:
> > Hi,
> > for GCompris we named the files org.kde.gcompris.appdata.xml and
> > org.kde.gcompris.desktop.
> > However, our binary file is gcompris-qt. According to
> > https://bugs.kde.org/show_bug.cgi?id=409996 (gcompris 0.96 has Wayland
> > generic icon when you press alt+tab) and after some research
> > (http://plfiorini.blogspot.com/2015/07/how-to-make-your-qt-application-icon.html),
> > it seems we should rename our desktop file to
> > org.kde.gcompris-qt.desktop
> >
> > Does changing the name is the good solution?
>
> I don't really have an answer for this. I would suggest asking the Plasma team
> for confirmation. They probably know also whether renaming has can make
> application managers think that this is a new program.
>
> > And if yes, do I just
> > have to change the filenames (for both) and the translation can be
> > automatically retrieved (or will I have to do some svn move)?
>
> A manual rename would be needed for the templates and the files, but I can
> help with that.
>
> Ciao
> --
> Luigi