Re: Review Request 122167: Unlink the temporary file for ShmPool from file system
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/ --- (Updated Jan. 26, 2015, 10:12 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kwayland Description --- By using unlink() we can ensure that the file will be deleted after the last file descriptor referring to it is closed. QTemporaryFile didn't clean up in case of e.g. crashes. Diffs - src/client/shm_pool.cpp c5d4a9f92ed2d4904ee999285b22b8218d8ff7f0 Diff: https://git.reviewboard.kde.org/r/122167/diff/ Testing --- run kwin_wayland with KWIN_COMPOSE=Q to enforce usage of ShmPool: no file listed for kwin in /tmp. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122167: Unlink the temporary file for ShmPool from file system
On Jan. 22, 2015, 1:27 p.m., Vishesh Handa wrote: Seems like a sensible thing. Though perhaps we should think about improving QTemporaryFile to do the same internally. I had a look at QTemporaryFile but I didn't dare to touch it in the end as it's cross platform and I have no idea what the implications for non-POSIX would be. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/#review74532 --- On Jan. 20, 2015, 10:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/ --- (Updated Jan. 20, 2015, 10:35 a.m.) Review request for Plasma. Repository: kwayland Description --- By using unlink() we can ensure that the file will be deleted after the last file descriptor referring to it is closed. QTemporaryFile didn't clean up in case of e.g. crashes. Diffs - src/client/shm_pool.cpp c5d4a9f92ed2d4904ee999285b22b8218d8ff7f0 Diff: https://git.reviewboard.kde.org/r/122167/diff/ Testing --- run kwin_wayland with KWIN_COMPOSE=Q to enforce usage of ShmPool: no file listed for kwin in /tmp. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122167: Unlink the temporary file for ShmPool from file system
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/#review74532 --- Ship it! Seems like a sensible thing. Though perhaps we should think about improving QTemporaryFile to do the same internally. - Vishesh Handa On Jan. 20, 2015, 9:35 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122167/ --- (Updated Jan. 20, 2015, 9:35 a.m.) Review request for Plasma. Repository: kwayland Description --- By using unlink() we can ensure that the file will be deleted after the last file descriptor referring to it is closed. QTemporaryFile didn't clean up in case of e.g. crashes. Diffs - src/client/shm_pool.cpp c5d4a9f92ed2d4904ee999285b22b8218d8ff7f0 Diff: https://git.reviewboard.kde.org/r/122167/diff/ Testing --- run kwin_wayland with KWIN_COMPOSE=Q to enforce usage of ShmPool: no file listed for kwin in /tmp. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
