Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Eike Hein]

> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.
> 
> Marco Martin wrote:
> hmm, can you explain what the problem in tooltip management is?

I tested the patch before I gave the Ship It!, and it worked just fine for me 
with latest plasma-framework. The Tooltip dialog docked at the screen edges 
left and right and the contents scrolled.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 25, 2015, 4:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ceb827322c3402ae08e88f60fbed7a09ed0a222b by David Rosca 
to branch master.


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!

Hmm, it no longer works because the tooltip size is not bound by the available 
screen size.
So it needs fix in plasma-framework first.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Marco Martin]

> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.

hmm, can you explain what the problem in tooltip management is?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.
> 
> Marco Martin wrote:
> hmm, can you explain what the problem in tooltip management is?
> 
> Eike Hein wrote:
> I tested the patch before I gave the Ship It!, and it worked just fine 
> for me with latest plasma-framework. The Tooltip dialog docked at the screen 
> edges left and right and the contents scrolled.

For some reason, it doesn't work for me (full kdesrc-build today) without

width: Math.min(Screen.availableDesktopWidth, Math.max(windowRow.width, 
appLabelRow.width)  + _s) 

eg. the contentItem.width == viewport.width even after the tooltip doesn't fit 
on screen.

Ok, so I'll commit it and then try to debug my local issue.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---

Ship it!


Ship It!

- Eike Hein


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88775
---


Ping

- David Rosca


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 5, 2015, 9:05 a.m.)


Review request for Plasma.


Changes
---

Fix alignment with only one window in tooltip


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs (updated)
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review87798
---


> One thing that would be great is to allow vertical wheel scrolling

That should work with PlasmaExtras.ScrollArea, if you can only scroll 
horizontally.

- Kai Uwe Broulik


On Nov. 1, 2015, 10:53 vorm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 1, 2015, 10:53 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review87797
---



applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 48)


This should probably be a PlasmaExtras.ScrollArea


- Eike Hein


On Nov. 1, 2015, 10:53 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 1, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 1, 2015, 2:26 p.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs (updated)
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 1, 2015, 1:56 p.m.)


Review request for Plasma.


Changes
---

Change to ScrollArea


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs (updated)
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review87801
---


> Remove expression for interactive as it doesn't work with ScrollArea anyway.

You need to override that in Component.onCompleted (eg. Component.onCompleted: 
flickableItem.interactive = Qt.binding(function() { return … }) since we 
override the interactive to workaround it also affecting keyboard input


applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 50)


The ScrollArea clips its viewport on its own


- Kai Uwe Broulik


On Nov. 1, 2015, 2:06 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 1, 2015, 2:06 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

> On Nov. 1, 2015, 1:25 p.m., Kai Uwe Broulik wrote:
> > > One thing that would be great is to allow vertical wheel scrolling
> > 
> > That should work with PlasmaExtras.ScrollArea, if you can only scroll 
> > horizontally.

It doesn't work (as it is with current diff)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review87798
---


On Nov. 1, 2015, 1:56 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 1, 2015, 1:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 1, 2015, 2:06 p.m.)


Review request for Plasma.


Changes
---

Remove expression for interactive as it doesn't work with ScrollArea anyway.


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs (updated)
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel