Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-19 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/
---

(Updated Nov. 19, 2015, 10:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit cc1a9b52119f4fa441dbc08d0188c03688d9768b by Kai Uwe 
Broulik to branch master.


Repository: plasma-desktop


Description
---

The no longer enabled tooltip also contained the uninstall button. This 
restores the uninstall functionality similar to the wallpaper dialog.

User-installed applets get an uninstall button. I chose to always show it 
rather than on hover since only a few applets are likely to be uninstallable 
and I don't want to play the guessing-game, perhaps we should introduce a 
filter for "User-installed applets" similar to the (less useful) "running" 
ones. Clicking the button will queue the uninstallation which can be cancelled 
anytime the dialog is still opened. As soon as the dialog closes, the actual 
uninstall is executed.

Multiple applets can be enqueued simultaneously.


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
  desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
  desktoppackage/contents/views/Desktop.qml b555fea 

Diff: https://git.reviewboard.kde.org/r/125991/diff/


Testing
---

Installed plasmoid through drag and drop, uninstalled after fixing an uninstall 
bug (Review 125990)

The tooltip says "Undo uninstall". I just noticed I should probably fade the 
applet name too.


File Attachments


Uninstall before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
Undo uninstall
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-19 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88578
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 17, 2015, 9:37 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 17, 2015, 9:37 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
>   desktoppackage/contents/views/Desktop.qml b555fea 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-18 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88548
---


Ping

I don't want to ease people installing applets (cf Review 125968) but then not 
provide a way to uninstall them :)

- Kai Uwe Broulik


On Nov. 17, 2015, 9:37 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 17, 2015, 9:37 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
>   desktoppackage/contents/views/Desktop.qml b555fea 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-17 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/
---

(Updated Nov. 17, 2015, 9:37 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

Timer stays running after widget explorer has closed. Re-opening it during the 
grace period allows to cancel uninstall. After 60 seconds the applet is 
eventually uninstalled.


Repository: plasma-desktop


Description
---

The no longer enabled tooltip also contained the uninstall button. This 
restores the uninstall functionality similar to the wallpaper dialog.

User-installed applets get an uninstall button. I chose to always show it 
rather than on hover since only a few applets are likely to be uninstallable 
and I don't want to play the guessing-game, perhaps we should introduce a 
filter for "User-installed applets" similar to the (less useful) "running" 
ones. Clicking the button will queue the uninstallation which can be cancelled 
anytime the dialog is still opened. As soon as the dialog closes, the actual 
uninstall is executed.

Multiple applets can be enqueued simultaneously.


Diffs (updated)
-

  desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
  desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
  desktoppackage/contents/views/Desktop.qml b555fea 

Diff: https://git.reviewboard.kde.org/r/125991/diff/


Testing
---

Installed plasmoid through drag and drop, uninstalled after fixing an uninstall 
bug (Review 125990)

The tooltip says "Undo uninstall". I just noticed I should probably fade the 
applet name too.


File Attachments


Uninstall before
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
Undo uninstall
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88421
---


otherwise, looks good to me. I'll let others weigh in as well.


desktoppackage/contents/explorer/AppletDelegate.qml (line 81)


0.6 is more common (yes, I know, hardcoding this bites us more often than 
not)



desktoppackage/contents/explorer/AppletDelegate.qml (line 171)


please also specify top (I know, it's default here, but it feels a lot more 
correct)


- Sebastian Kügler


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88427
---


Note to self: Disable drag area when applet is pending uninstall

- Kai Uwe Broulik


On Nov. 8, 2015, 12:23 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Thomas Pfeiffer


> On Nov. 8, 2015, 3:37 p.m., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)
> 
> Kai Uwe Broulik wrote:
> So basically like it is now, except I add an overlay saying "Uninstalled" 
> with a more prominent Undo button.

The reason why I suggested doing it like we do with Plasmoids is simply 
consistency. The more knowledge users can transfer from one area to another, 
the better. Undoing an uninstall should not be such a common thing (unless you 
are a user who constantly clicks the wrong things), so I believe that 
consistency is more important than comfort.

That said, Marco's suggestions makes sense to me as well. It would look similar 
to the Plasmoid mechanism while keeping in the same place.

The downside I see is that if one clicks uninstall, closes the widget explorer 
(because one thinks the task is complete) and in the next split second realized 
"Oh fuck, that was the wrong one!", it's too late. With a notification, one has 
much more time to undo the action.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Martin Klapetek


> On Nov. 8, 2015, 4:37 p.m., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)
> 
> Kai Uwe Broulik wrote:
> So basically like it is now, except I add an overlay saying "Uninstalled" 
> with a more prominent Undo button.
> 
> Thomas Pfeiffer wrote:
> The reason why I suggested doing it like we do with Plasmoids is simply 
> consistency. The more knowledge users can transfer from one area to another, 
> the better. Undoing an uninstall should not be such a common thing (unless 
> you are a user who constantly clicks the wrong things), so I believe that 
> consistency is more important than comfort.
> 
> That said, Marco's suggestions makes sense to me as well. It would look 
> similar to the Plasmoid mechanism while keeping in the same place.
> 
> The downside I see is that if one clicks uninstall, closes the widget 
> explorer (because one thinks the task is complete) and in the next split 
> second realized "Oh fuck, that was the wrong one!", it's too late. With a 
> notification, one has much more time to undo the action.

Ideally there should be a timeout, just like with the notification, before it 
disappears. Like for 1 minute, it will stay there and then disappear altogether.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 1:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 1:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Thomas Pfeiffer


> On Nov. 8, 2015, 3:37 p.m., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)
> 
> Kai Uwe Broulik wrote:
> So basically like it is now, except I add an overlay saying "Uninstalled" 
> with a more prominent Undo button.
> 
> Thomas Pfeiffer wrote:
> The reason why I suggested doing it like we do with Plasmoids is simply 
> consistency. The more knowledge users can transfer from one area to another, 
> the better. Undoing an uninstall should not be such a common thing (unless 
> you are a user who constantly clicks the wrong things), so I believe that 
> consistency is more important than comfort.
> 
> That said, Marco's suggestions makes sense to me as well. It would look 
> similar to the Plasmoid mechanism while keeping in the same place.
> 
> The downside I see is that if one clicks uninstall, closes the widget 
> explorer (because one thinks the task is complete) and in the next split 
> second realized "Oh fuck, that was the wrong one!", it's too late. With a 
> notification, one has much more time to undo the action.
> 
> Martin Klapetek wrote:
> Ideally there should be a timeout, just like with the notification, 
> before it disappears. Like for 1 minute, it will stay there and then 
> disappear altogether.

So re-opening the widget explorer during that timeout would still shout the 
undo button?
That would work.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Kai Uwe Broulik


> On Nov. 8, 2015, 3:37 nachm., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)
> 
> Kai Uwe Broulik wrote:
> So basically like it is now, except I add an overlay saying "Uninstalled" 
> with a more prominent Undo button.
> 
> Thomas Pfeiffer wrote:
> The reason why I suggested doing it like we do with Plasmoids is simply 
> consistency. The more knowledge users can transfer from one area to another, 
> the better. Undoing an uninstall should not be such a common thing (unless 
> you are a user who constantly clicks the wrong things), so I believe that 
> consistency is more important than comfort.
> 
> That said, Marco's suggestions makes sense to me as well. It would look 
> similar to the Plasmoid mechanism while keeping in the same place.
> 
> The downside I see is that if one clicks uninstall, closes the widget 
> explorer (because one thinks the task is complete) and in the next split 
> second realized "Oh fuck, that was the wrong one!", it's too late. With a 
> notification, one has much more time to undo the action.
> 
> Martin Klapetek wrote:
> Ideally there should be a timeout, just like with the notification, 
> before it disappears. Like for 1 minute, it will stay there and then 
> disappear altogether.
> 
> Thomas Pfeiffer wrote:
> So re-opening the widget explorer during that timeout would still shout 
> the undo button?
> That would work.

If I stored the pending deletions in the Desktop.qml rather than the 
WidgetExplorer.qml (not sure I want to do that though) they would survive the 
widget explorer closing. I would not do separate timers (to not complicate 
things), though, but always 1 minute after the last widget I deleted (and 
restart the timer if you delete another one in the meantime) it would remove 
all pending ones.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___

Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Thomas Pfeiffer


> On Nov. 8, 2015, 3:37 p.m., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)
> 
> Kai Uwe Broulik wrote:
> So basically like it is now, except I add an overlay saying "Uninstalled" 
> with a more prominent Undo button.
> 
> Thomas Pfeiffer wrote:
> The reason why I suggested doing it like we do with Plasmoids is simply 
> consistency. The more knowledge users can transfer from one area to another, 
> the better. Undoing an uninstall should not be such a common thing (unless 
> you are a user who constantly clicks the wrong things), so I believe that 
> consistency is more important than comfort.
> 
> That said, Marco's suggestions makes sense to me as well. It would look 
> similar to the Plasmoid mechanism while keeping in the same place.
> 
> The downside I see is that if one clicks uninstall, closes the widget 
> explorer (because one thinks the task is complete) and in the next split 
> second realized "Oh fuck, that was the wrong one!", it's too late. With a 
> notification, one has much more time to undo the action.
> 
> Martin Klapetek wrote:
> Ideally there should be a timeout, just like with the notification, 
> before it disappears. Like for 1 minute, it will stay there and then 
> disappear altogether.
> 
> Thomas Pfeiffer wrote:
> So re-opening the widget explorer during that timeout would still shout 
> the undo button?
> That would work.
> 
> Kai Uwe Broulik wrote:
> If I stored the pending deletions in the Desktop.qml rather than the 
> WidgetExplorer.qml (not sure I want to do that though) they would survive the 
> widget explorer closing. I would not do separate timers (to not complicate 
> things), though, but always 1 minute after the last widget I deleted (and 
> restart the timer if you delete another one in the meantime) it would remove 
> all pending ones.

I believe surviving the widget explorer closing would be important so that a 
single click would not delete them permanently.
The proposed timer logic totally makes sense to me.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   

Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Kai Uwe Broulik


> On Nov. 8, 2015, 3:37 nachm., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.
> 
> Marco Martin wrote:
> not so sure it it would work there..
> maybe just adding an overlay to the applet thumbnail a "deleted" with and 
> undo button and actually uninstall all of them when the widget expolorer gets 
> closed (again, not sure is a good idea)

So basically like it is now, except I add an overlay saying "Uninstalled" with 
a more prominent Undo button.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-16 Thread Marco Martin


> On Nov. 8, 2015, 3:37 p.m., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?
> 
> Kai Uwe Broulik wrote:
> So you want the thing to be removed from the list immediately when I 
> press delete and then we spawn a notification on the opposite side of the 
> screen? Doesn't sound too usable for me given the widget explorer is always 
> on the left side of the screen.

not so sure it it would work there..
maybe just adding an overlay to the applet thumbnail a "deleted" with and undo 
button and actually uninstall all of them when the widget expolorer gets closed 
(again, not sure is a good idea)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-15 Thread Kai Uwe Broulik


> On Nov. 8, 2015, 3:37 nachm., Thomas Pfeiffer wrote:
> > Showing it always does make sense as long as it affects only a few 
> > Plasmoids, yes.
> > About the undo: I'm wondering if it might make sense - for consistency's 
> > sake - to do the undo mechanism similar to undoing the removal of a 
> > Plasmoid from the desktop/panel, i.e. via a button in a notification 
> > confirming about the completed deinstallation?

So you want the thing to be removed from the list immediately when I press 
delete and then we spawn a notification on the opposite side of the screen? 
Doesn't sound too usable for me given the widget explorer is always on the left 
side of the screen.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


On Nov. 8, 2015, 12:23 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 vorm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-08 Thread Thomas Pfeiffer

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125991/#review88162
---


Showing it always does make sense as long as it affects only a few Plasmoids, 
yes.
About the undo: I'm wondering if it might make sense - for consistency's sake - 
to do the undo mechanism similar to undoing the removal of a Plasmoid from the 
desktop/panel, i.e. via a button in a notification confirming about the 
completed deinstallation?

- Thomas Pfeiffer


On Nov. 8, 2015, 12:23 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125991/
> ---
> 
> (Updated Nov. 8, 2015, 12:23 a.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The no longer enabled tooltip also contained the uninstall button. This 
> restores the uninstall functionality similar to the wallpaper dialog.
> 
> User-installed applets get an uninstall button. I chose to always show it 
> rather than on hover since only a few applets are likely to be uninstallable 
> and I don't want to play the guessing-game, perhaps we should introduce a 
> filter for "User-installed applets" similar to the (less useful) "running" 
> ones. Clicking the button will queue the uninstallation which can be 
> cancelled anytime the dialog is still opened. As soon as the dialog closes, 
> the actual uninstall is executed.
> 
> Multiple applets can be enqueued simultaneously.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 5a81b91 
>   desktoppackage/contents/explorer/WidgetExplorer.qml af27229 
> 
> Diff: https://git.reviewboard.kde.org/r/125991/diff/
> 
> 
> Testing
> ---
> 
> Installed plasmoid through drag and drop, uninstalled after fixing an 
> uninstall bug (Review 125990)
> 
> The tooltip says "Undo uninstall". I just noticed I should probably fade the 
> applet name too.
> 
> 
> File Attachments
> 
> 
> Uninstall before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/adcb91e0-a8c2-4481-89f1-139b4e716da3__uninstall1.png
> Undo uninstall
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/08/ebdae6ad-28bd-42f0-bb36-bfa6dfd3cc30__uninstall2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel