Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. > > Marco Martin wrote: > same here > > David Rosca wrote: > I would expect it to paste the content of X selection, not clipboard. That's at least what happens in the desktop containment -- middle click to paste (which creates a notes applet). So +1 for that. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- On Nov. 25, 2015, 2:18 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:18 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 --- Not so sure about this: Just clicking on it will publish information on an online service, that's hardly what a naive user would expect. On middle-click I think it would be fine, but a normal click is usually used to open some kind of popup, if we ship the clipboard to the internet in that case, we may be producing privacy leaks inadvertently. If you make it paste only on pressing the middle button, I'd be OK with this. - Sebastian Kügler On Nov. 25, 2015, 1:32 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 1:32 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open some kind of popup, if we ship the clipboard to the internet in > > that case, we may be producing privacy leaks inadvertently. > > > > If you make it paste only on pressing the middle button, I'd be OK with > > this. > > Aleix Pol Gonzalez wrote: > Just clicking will show the dialog with alternatives. It asks you first what to do and where to publish (in a popup), so no random uploads. Originally, I made it on middle click, but then I changed it to just left click because it already pastes on left click when it gets uri from activity manager. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 --- On Nov. 25, 2015, 1:32 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 1:32 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/ --- (Updated Nov. 25, 2015, 2:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit ca9b6310ceba285a67098b705b7015ae6202f21c by David Rosca to branch master. Repository: kdeplasma-addons Description --- It is now possible to paste with mouse click even when ContentTracker's uri is empty. Diffs - applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 Diff: https://git.reviewboard.kde.org/r/126165/diff/ Testing --- Works fine, I no longer need to open context menu and select Paste. Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 3:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open some kind of popup, if we ship the clipboard to the internet in > > that case, we may be producing privacy leaks inadvertently. > > > > If you make it paste only on pressing the middle button, I'd be OK with > > this. Just clicking will show the dialog with alternatives. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 --- On Nov. 25, 2015, 2:32 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:32 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88802 --- Ship it! Looks good! - Aleix Pol Gonzalez On Nov. 25, 2015, 2:32 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:32 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote: > > Not so sure about this: Just clicking on it will publish information on an > > online service, that's hardly what a naive user would expect. On > > middle-click I think it would be fine, but a normal click is usually used > > to open some kind of popup, if we ship the clipboard to the internet in > > that case, we may be producing privacy leaks inadvertently. > > > > If you make it paste only on pressing the middle button, I'd be OK with > > this. > > Aleix Pol Gonzalez wrote: > Just clicking will show the dialog with alternatives. > > David Rosca wrote: > It asks you first what to do and where to publish (in a popup), so no > random uploads. > > Originally, I made it on middle click, but then I changed it to just left > click because it already pastes on left click when it gets uri from activity > manager. Okay, thanks for the clarification! - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88801 --- On Nov. 25, 2015, 2:18 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:18 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- I would expect middle clicking to paste. - Kai Uwe Broulik On Nov. 25, 2015, 2:18 nachm., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:18 nachm.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. same here - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- On Nov. 25, 2015, 2:18 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:18 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click
> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > I would expect middle clicking to paste. > > Marco Martin wrote: > same here I would expect it to paste the content of X selection, not clipboard. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126165/#review88810 --- On Nov. 25, 2015, 2:18 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126165/ > --- > > (Updated Nov. 25, 2015, 2:18 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > --- > > It is now possible to paste with mouse click even when ContentTracker's uri > is empty. > > > Diffs > - > > applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 > > Diff: https://git.reviewboard.kde.org/r/126165/diff/ > > > Testing > --- > > Works fine, I no longer need to open context menu and select Paste. > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
