Re: Review Request 126166: use stylesheets in breeze icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/ --- (Updated Dec. 3, 2015, 5:20 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, andreas kainz and Uri Herrera. Changes --- Submitted with commit 6d2a8c0feb02c8d5491e27e0a2a372da750137ab by Marco Martin to branch master. Repository: breeze-icons Description --- unfortunately the diff was about 35 megabytes, so was too big for reviewboard little mind ;) a tarball of the modified icons can be found at http://notmart.org/misc/breeze-icons.tar.bz2 this changes the monochrome breeze icons (other icons are untouched) to use stylesheets instead of hardcoded colors, at least with text color for the black bits, background for the light bits. This is kinda needed for icons loaded in plasma (even tough some basic icons in the plasma theme systray and actions are still needed, less duplication would be needed) Will be needed a bit more stringently in plasma mobile, where the plasma theme is used as theme for applications (and probably some effects will be needed like changing icons from black to white on the fly) This change is not supposed to change the look of any icon anywhere: for desktop applications all of them should look *exactly* the same as they did (please doublecheck this ;)) Diffs - CMakeLists.txt 886ab74 Diff: https://git.reviewboard.kde.org/r/126166/diff/ Testing --- Thanks, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. > > Marco Martin wrote: > anyways, if the status in the tarball is still current, would be good to > apply it, as I see so far only system-lock-screen has diverged (and a > mimetype added) > > andreas kainz wrote: > hi > > I don't know how I can test them but I would prefere an automatic > solution also for applications cause some applications want to use dark > background and than the icons should be automatic the dark ones. as we have > dark and light icons why you don't say plasma dark is used => use dark icons > and at the applications the same dark color scheme => dark icons. we can also > use the stylesheet script but than we should reduce the icon set to breeze > and breeze dark was generated via stylesheet. > > sorry for the late replay I didn't have spare time in the past weeks. > > Marco Martin wrote: > the testing i'm interested in, is just to see that they don't change > their look when used in normal applications or opened in inkscape. > i need this stylesheet thing in plasma as in plsma mobile we are going to > have different areas where the icon can be either dark or light in the same > application, plus applications that define their own color. > Desktop applications have an old broken way to load icons and there is > nothing that can be done, but i don't want to keep being pushed back by that > for QML applications that don't have the same limits. > And yeah, would be quite silly to use a patched clone of the breeze icons > for plasma mobile, but that's how we need monochrome icons to be done. > > andreas kainz wrote: > I open an file with inkscape delete everything say clear file and make > everything new. It works. so I would say ship it. but I will have an solution > for kde applications also. > > andreas kainz wrote: > I add some icons in icons/status/22 folder so this icons are missing in > your diff. Ok, I adjusted those too - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Dec. 3, 2015, 5:20 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Dec. 3, 2015, 5:20 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco
Re: Review Request 126166: use stylesheets in breeze icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review89060 --- Ship it! Ship It! - andreas kainz On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. > > Marco Martin wrote: > anyways, if the status in the tarball is still current, would be good to > apply it, as I see so far only system-lock-screen has diverged (and a > mimetype added) > > andreas kainz wrote: > hi > > I don't know how I can test them but I would prefere an automatic > solution also for applications cause some applications want to use dark > background and than the icons should be automatic the dark ones. as we have > dark and light icons why you don't say plasma dark is used => use dark icons > and at the applications the same dark color scheme => dark icons. we can also > use the stylesheet script but than we should reduce the icon set to breeze > and breeze dark was generated via stylesheet. > > sorry for the late replay I didn't have spare time in the past weeks. > > Marco Martin wrote: > the testing i'm interested in, is just to see that they don't change > their look when used in normal applications or opened in inkscape. > i need this stylesheet thing in plasma as in plsma mobile we are going to > have different areas where the icon can be either dark or light in the same > application, plus applications that define their own color. > Desktop applications have an old broken way to load icons and there is > nothing that can be done, but i don't want to keep being pushed back by that > for QML applications that don't have the same limits. > And yeah, would be quite silly to use a patched clone of the breeze icons > for plasma mobile, but that's how we need monochrome icons to be done. I open an file with inkscape delete everything say clear file and make everything new. It works. so I would say ship it. but I will have an solution for kde applications also. - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. > > Marco Martin wrote: > anyways, if the status in the tarball is still current, would be good to > apply it, as I see so far only system-lock-screen has diverged (and a > mimetype added) > > andreas kainz wrote: > hi > > I don't know how I can test them but I would prefere an automatic > solution also for applications cause some applications want to use dark > background and than the icons should be automatic the dark ones. as we have > dark and light icons why you don't say plasma dark is used => use dark icons > and at the applications the same dark color scheme => dark icons. we can also > use the stylesheet script but than we should reduce the icon set to breeze > and breeze dark was generated via stylesheet. > > sorry for the late replay I didn't have spare time in the past weeks. the testing i'm interested in, is just to see that they don't change their look when used in normal applications or opened in inkscape. i need this stylesheet thing in plasma as in plsma mobile we are going to have different areas where the icon can be either dark or light in the same application, plus applications that define their own color. Desktop applications have an old broken way to load icons and there is nothing that can be done, but i don't want to keep being pushed back by that for QML applications that don't have the same limits. And yeah, would be quite silly to use a patched clone of the breeze icons for plasma mobile, but that's how we need monochrome icons to be done. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. > > Marco Martin wrote: > anyways, if the status in the tarball is still current, would be good to > apply it, as I see so far only system-lock-screen has diverged (and a > mimetype added) hi I don't know how I can test them but I would prefere an automatic solution also for applications cause some applications want to use dark background and than the icons should be automatic the dark ones. as we have dark and light icons why you don't say plasma dark is used => use dark icons and at the applications the same dark color scheme => dark icons. we can also use the stylesheet script but than we should reduce the icon set to breeze and breeze dark was generated via stylesheet. sorry for the late replay I didn't have spare time in the past weeks. - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. > > Marco Martin wrote: > anyways, if the status in the tarball is still current, would be good to > apply it, as I see so far only system-lock-screen has diverged (and a > mimetype added) > > andreas kainz wrote: > hi > > I don't know how I can test them but I would prefere an automatic > solution also for applications cause some applications want to use dark > background and than the icons should be automatic the dark ones. as we have > dark and light icons why you don't say plasma dark is used => use dark icons > and at the applications the same dark color scheme => dark icons. we can also > use the stylesheet script but than we should reduce the icon set to breeze > and breeze dark was generated via stylesheet. > > sorry for the late replay I didn't have spare time in the past weeks. > > Marco Martin wrote: > the testing i'm interested in, is just to see that they don't change > their look when used in normal applications or opened in inkscape. > i need this stylesheet thing in plasma as in plsma mobile we are going to > have different areas where the icon can be either dark or light in the same > application, plus applications that define their own color. > Desktop applications have an old broken way to load icons and there is > nothing that can be done, but i don't want to keep being pushed back by that > for QML applications that don't have the same limits. > And yeah, would be quite silly to use a patched clone of the breeze icons > for plasma mobile, but that's how we need monochrome icons to be done. > > andreas kainz wrote: > I open an file with inkscape delete everything say clear file and make > everything new. It works. so I would say ship it. but I will have an solution > for kde applications also. I add some icons in icons/status/22 folder so this icons are missing in your diff. - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > >
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. If I run apply-stylesheet.sh in icons that don't have the attribute the script will add it? or would I have to run currentColorFix.sh first and then apply-stylesheet.sh?. - Uri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. it should add it, it depends also what are the colors used, as in those icons the monochrome dark color is #4d4d4d, would need the parameters --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with the TextColor class. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. > > Marco Martin wrote: > the documentation talking about it so far is > > https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors > > I know is just a small paragraph, but i'm not sure what's needed more to > be clearly understandable.. I can expand on that if I am explained the > unclear points. > > Uri Herrera wrote: > If I run apply-stylesheet.sh in icons that don't have the attribute the > script will add it? or would I have to run currentColorFix.sh first and then > apply-stylesheet.sh?. > > Marco Martin wrote: > it should add it, it depends also what are the colors used, as in those > icons the monochrome dark color is #4d4d4d, would need the parameters > --TextFrom=#4d4d4d --TextTo=#4d4d4d that tells what color to replace with > the TextColor class. anyways, if the status in the tarball is still current, would be good to apply it, as I see so far only system-lock-screen has diverged (and a mimetype added) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- *please* VDG people, take a look at this asap. I already seen that new changes have been done to icons in master, which means that i'll have to redo this from scratch. - Marco Martin On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. This needs to be documented first. Properly. Once it's documented then we'll go on with the change. - Uri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > This needs to be documented first. Properly. Once it's documented then > we'll go on with the change. the documentation talking about it so far is https://techbase.kde.org/Development/Tutorials/Plasma5/ThemeDetails#Using_system_colors I know is just a small paragraph, but i'm not sure what's needed more to be clearly understandable.. I can expand on that if I am explained the unclear points. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88869 --- On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126166: use stylesheets in breeze icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126166/#review88799 --- Ship it! Ship It! - Sebastian Kügler On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126166/ > --- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboard > little mind ;) > a tarball of the modified icons can be found at > http://notmart.org/misc/breeze-icons.tar.bz2 > this changes the monochrome breeze icons (other icons are untouched) to use > stylesheets instead of hardcoded colors, at least with text color for the > black bits, background for the light bits. > This is kinda needed for icons loaded in plasma (even tough some basic icons > in the plasma theme systray and actions are still needed, less duplication > would be needed) > Will be needed a bit more stringently in plasma mobile, where the plasma > theme is used as theme for applications (and probably some effects will be > needed like changing icons from black to white on the fly) > > This change is not supposed to change the look of any icon anywhere: for > desktop applications all of them should look *exactly* the same as they did > (please doublecheck this ;)) > > > Diffs > - > > CMakeLists.txt 886ab74 > > Diff: https://git.reviewboard.kde.org/r/126166/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
