Re: Review Request 126178: [Kicker] Add support for Jump Lists
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/ --- (Updated Nov. 27, 2015, 6:29 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, KDE Usability and Eike Hein. Changes --- Submitted with commit 49ca2ee6bbd9278bd80bbf4b192271efcbe81c8c by Kai Uwe Broulik to branch master. Repository: plasma-desktop Description --- This adds support for "Additional applications actions" (aka Jumplists). Not sure about the "Tasks" heading. I probably added it to provide more separation to the (kinda out of place "remove from favorites"). Note to Usability: The exact same functionality will also be available to Kickoff and the Application Dashboard. Also, the two actions shown for Kate I added myself for testing; they are kinda useless and won't be shipped. Chromium doesn't have recent documents, so I added to showcase when both list types are available. Diffs - applets/kicker/plugin/actionlist.h 7a543da applets/kicker/plugin/actionlist.cpp 87c9b51 applets/kicker/plugin/appentry.cpp ecb18ac applets/kicker/plugin/recentusagemodel.cpp bd9efa1 Diff: https://git.reviewboard.kde.org/r/126178/diff/ Testing --- Works for applications. Could not test history as I could get neither chromium nor kate to show up there. Also a pity that none of these features are available to search results. File Attachments Kicker Jump List https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126178: [Kicker] Add support for Jump Lists
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/ --- (Updated Nov. 26, 2015, 11:39 nachm.) Review request for Plasma, KDE Usability and Eike Hein. Changes --- - Place "Add to panel/desktop/launcher" items at bottom of "Tasks", between Tasks and Recent Documents - Get rid of "Tasks" heading See Review 126179 for how that looks Repository: plasma-desktop Description --- This adds support for "Additional applications actions" (aka Jumplists). Not sure about the "Tasks" heading. I probably added it to provide more separation to the (kinda out of place "remove from favorites"). Note to Usability: The exact same functionality will also be available to Kickoff and the Application Dashboard. Also, the two actions shown for Kate I added myself for testing; they are kinda useless and won't be shipped. Chromium doesn't have recent documents, so I added to showcase when both list types are available. Diffs (updated) - applets/kicker/plugin/actionlist.h 7a543da applets/kicker/plugin/actionlist.cpp 87c9b51 applets/kicker/plugin/appentry.cpp ecb18ac applets/kicker/plugin/recentusagemodel.cpp bd9efa1 Diff: https://git.reviewboard.kde.org/r/126178/diff/ Testing --- Works for applications. Could not test history as I could get neither chromium nor kate to show up there. Also a pity that none of these features are available to search results. File Attachments Kicker Jump List https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126178: [Kicker] Add support for Jump Lists
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/#review8 --- Ship it! Ship It! - Eike Hein On Nov. 26, 2015, 11:39 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126178/ > --- > > (Updated Nov. 26, 2015, 11:39 p.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Repository: plasma-desktop > > > Description > --- > > This adds support for "Additional applications actions" (aka Jumplists). > > Not sure about the "Tasks" heading. I probably added it to provide more > separation to the (kinda out of place "remove from favorites"). > > Note to Usability: The exact same functionality will also be available to > Kickoff and the Application Dashboard. Also, the two actions shown for Kate I > added myself for testing; they are kinda useless and won't be shipped. > Chromium doesn't have recent documents, so I added to showcase when both list > types are available. > > > Diffs > - > > applets/kicker/plugin/actionlist.h 7a543da > applets/kicker/plugin/actionlist.cpp 87c9b51 > applets/kicker/plugin/appentry.cpp ecb18ac > applets/kicker/plugin/recentusagemodel.cpp bd9efa1 > > Diff: https://git.reviewboard.kde.org/r/126178/diff/ > > > Testing > --- > > Works for applications. Could not test history as I could get neither > chromium nor kate to show up there. Also a pity that none of these features > are available to search results. > > > File Attachments > > > Kicker Jump List > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126178: [Kicker] Add support for Jump Lists
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/#review88875 --- How about we make the heading "Actions" and roll the Add * actions in there? - Eike Hein On Nov. 26, 2015, 7:52 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126178/ > --- > > (Updated Nov. 26, 2015, 7:52 p.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Repository: plasma-desktop > > > Description > --- > > This adds support for "Additional applications actions" (aka Jumplists). > > Not sure about the "Tasks" heading. I probably added it to provide more > separation to the (kinda out of place "remove from favorites"). > > Note to Usability: The exact same functionality will also be available to > Kickoff and the Application Dashboard. Also, the two actions shown for Kate I > added myself for testing; they are kinda useless and won't be shipped. > Chromium doesn't have recent documents, so I added to showcase when both list > types are available. > > > Diffs > - > > applets/kicker/plugin/actionlist.h 7a543da > applets/kicker/plugin/actionlist.cpp 87c9b51 > applets/kicker/plugin/appentry.cpp ecb18ac > applets/kicker/plugin/recentusagemodel.cpp bd9efa1 > > Diff: https://git.reviewboard.kde.org/r/126178/diff/ > > > Testing > --- > > Works for applications. Could not test history as I could get neither > chromium nor kate to show up there. Also a pity that none of these features > are available to search results. > > > File Attachments > > > Kicker Jump List > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126178: [Kicker] Add support for Jump Lists
> On Nov. 26, 2015, 8:01 p.m., Eike Hein wrote: > > How about we make the heading "Actions" and roll the Add * actions in there? > Also a pity that none of these features are available to search results. This on my todo BTW (note that Kickoff previously didn't even support favoriting for search results though). - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126178/#review88875 --- On Nov. 26, 2015, 7:52 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126178/ > --- > > (Updated Nov. 26, 2015, 7:52 p.m.) > > > Review request for Plasma, KDE Usability and Eike Hein. > > > Repository: plasma-desktop > > > Description > --- > > This adds support for "Additional applications actions" (aka Jumplists). > > Not sure about the "Tasks" heading. I probably added it to provide more > separation to the (kinda out of place "remove from favorites"). > > Note to Usability: The exact same functionality will also be available to > Kickoff and the Application Dashboard. Also, the two actions shown for Kate I > added myself for testing; they are kinda useless and won't be shipped. > Chromium doesn't have recent documents, so I added to showcase when both list > types are available. > > > Diffs > - > > applets/kicker/plugin/actionlist.h 7a543da > applets/kicker/plugin/actionlist.cpp 87c9b51 > applets/kicker/plugin/appentry.cpp ecb18ac > applets/kicker/plugin/recentusagemodel.cpp bd9efa1 > > Diff: https://git.reviewboard.kde.org/r/126178/diff/ > > > Testing > --- > > Works for applications. Could not test history as I could get neither > chromium nor kate to show up there. Also a pity that none of these features > are available to search results. > > > File Attachments > > > Kicker Jump List > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/26/e614da13-8e9a-4d42-b54e-8c6ab4af5f12__kickeractions.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
