Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91550 --- Hello! There is a typo in file ksolidnotify.cpp:166, also shown in third screenshot. - Antonis Geralis On Jan. 24, 2016, 9:40 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 24, 2016, 9:40 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/ --- (Updated Jan. 25, 2016, 12:40 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit 1ed7209f08aa69cec7847c606da8a2fc091dc603 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- Instead of showing a detached status bar with the device name, show the message below the device. When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears. This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier Diffs - applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca dataengines/devicenotifications/ksolidnotify.h fac8cc1 dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 Diff: https://git.reviewboard.kde.org/r/126688/diff/ Testing --- There a still a couple of glitches: - the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug) - sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug) - the "no devices" heading doesn't know that there's still a pseudo-device there - it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though - the message doesn't disappear reliably or spontaneously re-appears - depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one File Attachments Failed to mount https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png Safely remove https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png Emblem icon https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png Emblem-error https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png emblem-information https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 24, 2016, 10:26 nachm., Antonis Geralis wrote: > > Hello! There is a typo in file ksolidnotify.cpp:166, also shown in third > > screenshot. Well spotted. Fixed, thanks. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91550 --- On Jan. 24, 2016, 9:40 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 24, 2016, 9:40 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91408 --- Ship it! Ship It! - Heiko Tietze On Jan. 11, 2016, 4:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 11, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > > to showing the icon next to the message and maybe adding a faint highlight > > behind the item. > > Heiko Tietze wrote: > Better than coloring or higlighting parts of the UI you improve > positioning and spacing of controls. That means in this case to indent the > device information. > > Kai Uwe Broulik wrote: > Indent what? where? > > Heiko Tietze wrote: > Sorry, I was completely wrong. The term 'style' put me to the wrong > track, but actually you wanted to indicate the selection. Well done. > > Kai Uwe Broulik wrote: > I now made it so the selection rectangle shows up behind the device that > shows a message and slowly disappears (3s), I think that works nicely. sooo, the latest version is good enough to go in? let's not make it rot there ;) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- On Jan. 11, 2016, 4:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91409 --- Ship it! Ship It! - andreas kainz On Jan. 11, 2016, 4:19 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > > to showing the icon next to the message and maybe adding a faint highlight > > behind the item. > > Heiko Tietze wrote: > Better than coloring or higlighting parts of the UI you improve > positioning and spacing of controls. That means in this case to indent the > device information. > > Kai Uwe Broulik wrote: > Indent what? where? > > Heiko Tietze wrote: > Sorry, I was completely wrong. The term 'style' put me to the wrong > track, but actually you wanted to indicate the selection. Well done. I now made it so the selection rectangle shows up behind the device that shows a message and slowly disappears (3s), I think that works nicely. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- On Jan. 11, 2016, 4:19 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > > to showing the icon next to the message and maybe adding a faint highlight > > behind the item. > > Heiko Tietze wrote: > Better than coloring or higlighting parts of the UI you improve > positioning and spacing of controls. That means in this case to indent the > device information. > > Kai Uwe Broulik wrote: > Indent what? where? Sorry, I was completely wrong. The term 'style' put me to the wrong track, but actually you wanted to indicate the selection. Well done. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- On Jan. 11, 2016, 4:19 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. > > andreas kainz wrote: > icon Name and size please > > andreas kainz wrote: > like the new overlay icons only emblem icons can be used as overlay icon > so say me the name and I will add Themen to the emblem folder. all other > icons are not useful for overlay. > > Kai Uwe Broulik wrote: > Icon name: I guess emblem-error and emblem-success (these don't exist in > the FDO spec) > Icon size: no idea, I guess an 8x8 variant and 16x16? > > andreas kainz wrote: > 8x8 should be enough I added some new emblem icons > https://share.kde.org/index.php/s/z1LkxYIOD6dXelP Nice! Those should work nicely, warning is spelled with an A, however :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > >
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. > > andreas kainz wrote: > icon Name and size please > > andreas kainz wrote: > like the new overlay icons only emblem icons can be used as overlay icon > so say me the name and I will add Themen to the emblem folder. all other > icons are not useful for overlay. > > Kai Uwe Broulik wrote: > Icon name: I guess emblem-error and emblem-success (these don't exist in > the FDO spec) > Icon size: no idea, I guess an 8x8 variant and 16x16? > > andreas kainz wrote: > 8x8 should be enough I added some new emblem icons > https://share.kde.org/index.php/s/z1LkxYIOD6dXelP > > Kai Uwe Broulik wrote: > Nice! Those should work nicely, warning is spelled with an A, however :) icons are in master - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 11, 2016, 4:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > >
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 11, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > > to showing the icon next to the message and maybe adding a faint highlight > > behind the item. > > Heiko Tietze wrote: > Better than coloring or higlighting parts of the UI you improve > positioning and spacing of controls. That means in this case to indent the > device information. Indent what? where? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- On Jan. 11, 2016, 4:19 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 11, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > > to showing the icon next to the message and maybe adding a faint highlight > > behind the item. Better than coloring or higlighting parts of the UI you improve positioning and spacing of controls. That means in this case to indent the device information. - Heiko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- On Jan. 11, 2016, 4:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/ --- (Updated Jan. 11, 2016, 4:19 nachm.) Review request for Plasma and KDE Usability. Changes --- * Work around the "no devices" heading overlapping if there's a delayRemove item * Use emblem-information (I did not want to use emblem-success as it looks the same as the mounted icon) and emblem-error , please add them to the Breeze icon theme * Try harder to keep the delegate heights sane * Reduce device disappearance delay to 3s (from 5s) to be consistent with the time at which it will collapse again Repository: plasma-workspace Description --- Instead of showing a detached status bar with the device name, show the message below the device. When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears. This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier Diffs (updated) - applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca dataengines/devicenotifications/ksolidnotify.h fac8cc1 dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 Diff: https://git.reviewboard.kde.org/r/126688/diff/ Testing --- There a still a couple of glitches: - the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug) - sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug) - the "no devices" heading doesn't know that there's still a pseudo-device there - it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though - the message doesn't disappear reliably or spontaneously re-appears - depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one File Attachments (updated) Failed to mount https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png Safely remove https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png Emblem icon https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png Emblem-error https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png emblem-information https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90936 --- Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png While I'm not a huge fan of that excessive green background I agree that perhaps the message should be more prominently displayed, ie. moving back to showing the icon next to the message and maybe adding a faint highlight behind the item. - Kai Uwe Broulik On Jan. 11, 2016, 4:19 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 11, 2016, 4:19 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml a410e25 > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > applets/devicenotifier/package/contents/ui/devicenotifier.qml 29cdaca > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > Emblem-error > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/cf96b627-535d-404a-9330-61b171ebda3b__devicenotifierinlinefeedback4.png > emblem-information > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/11/1ee27871-65f8-4fc2-ae43-1c31a197578d__devicenotifierinlinefeedback5.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. please make the status icons smaller than the device icons. - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/ --- (Updated Jan. 10, 2016, 8:44 nachm.) Review request for Plasma and KDE Usability. Changes --- * Use emblem icon * Try harder to prevent the message from spontaneously re-appearing * Change wording from "The device can now be safely removed" to "This device can now be safely removed" Repository: plasma-workspace Description --- Instead of showing a detached status bar with the device name, show the message below the device. When removing a device, device notifier will pop up and a "You can now safely remove this device" message will show up; after 5 seconds the message and the device will disappear. When trying to unmount a device and it fails, device notifier will show up with an error message that will stay there until device notifier is closed or another message appears. This review consists of two patches: one for fixing the device notifications engine's wording (I'm open to better verbalizations) and one for the device notifier Diffs (updated) - applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 dataengines/devicenotifications/ksolidnotify.h fac8cc1 dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 Diff: https://git.reviewboard.kde.org/r/126688/diff/ Testing --- There a still a couple of glitches: - the layout doesn't properly reset at times (eg. the delegate height doesn't update) or fails to show certain items (also looks like a Qt bug) - sometimes the delegates suddenly overlap each other beacuse the section thing gets confused when the one item is already gone in the model (looks like a Qt bug) - the "no devices" heading doesn't know that there's still a pseudo-device there - it cannot actually highlight the device that was safely removed (it's no longer part of the model and thus has no index), we could do a hack for this though - the message doesn't disappear reliably or spontaneously re-appears - depending on your screen dpi you sometimes get a black and white Info icon but the error thing is always red, there's a smaller variant for the former but not the latter apparently, also it seems we lack a proper "task done" icon, Oxygen had one File Attachments (updated) Failed to mount https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png Safely remove https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png Emblem icon https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. Btw I need proper icons for the success and error case. dialog-information provides a black and white 22/24 size icon which doesn't work when used as overlay dialog-error looks okay'ish but also is clearly not meant to be used as badge. The icon for vcs-conflicting and vcs-normal would work but I need them with a proper name, of course, or something like task-complete and task-reject as provided by Oxygen. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. > > andreas kainz wrote: > icon Name and size please like the new overlay icons only emblem icons can be used as overlay icon so say me the name and I will add Themen to the emblem folder. all other icons are not useful for overlay. - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. icon Name and size please - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. > > andreas kainz wrote: > icon Name and size please > > andreas kainz wrote: > like the new overlay icons only emblem icons can be used as overlay icon > so say me the name and I will add Themen to the emblem folder. all other > icons are not useful for overlay. Icon name: I guess emblem-error and emblem-success (these don't exist in the FDO spec) Icon size: no idea, I guess an 8x8 variant and 16x16? - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/607af6d4-7533-4b1f-b483-182afe9b4173__devicenotifierinlinefeedback3.png > > > Thanks, > > Kai Uwe Broulik
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. > > Thomas Pfeiffer wrote: > Using an emblem sounds reasonable, though we would have to test whether > it's recognizeable at a glance. > > andreas kainz wrote: > please make the status icons smaller than the device icons. > > Kai Uwe Broulik wrote: > Btw I need proper icons for the success and error case. > dialog-information provides a black and white 22/24 size icon which > doesn't work when used as overlay > dialog-error looks okay'ish but also is clearly not meant to be used as > badge. > > The icon for vcs-conflicting and vcs-normal would work but I need them > with a proper name, of course, or something like task-complete and > task-reject as provided by Oxygen. > > andreas kainz wrote: > icon Name and size please > > andreas kainz wrote: > like the new overlay icons only emblem icons can be used as overlay icon > so say me the name and I will add Themen to the emblem folder. all other > icons are not useful for overlay. > > Kai Uwe Broulik wrote: > Icon name: I guess emblem-error and emblem-success (these don't exist in > the FDO spec) > Icon size: no idea, I guess an 8x8 variant and 16x16? 8x8 should be enough I added some new emblem icons https://share.kde.org/index.php/s/z1LkxYIOD6dXelP - andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 10, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 10, 2016, 8:44 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > Emblem icon > >
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) Please no italic text. Another idea would be having an emblem on the device icon, we indicate mounted vs not mounted, so we could show error / success there as well/instead. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 9, 2016, 8:15 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90823 --- Nice idea! I'd set the dely until the popup closes again shorter, though. This is just a feedback message that things happened as expected, so throwing the popup in the user's face for five seconds is too much distraction in that case (especially as nothing bad happens if the user misses the feedback). I'd just use the standard notification delay (or is that five seconds?). When unmounting failed, however, it should stay for five seconds because it's important that the user knows that the should not unplug the device. - Thomas Pfeiffer On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- Very nice! Gut feeling feedback: - the error message's icon could take the place of the eject icon - the "safely remove" icon could go away, text made italic (not sure if there's prior art in the HIG, I'm just imagining it would look less invasive) - Sebastian Kügler On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just imagining it would look less > > invasive) > > Kai Uwe Broulik wrote: > Please no italic text. Another idea would be having an emblem on the > device icon, we indicate mounted vs not mounted, so we could show error / > success there as well/instead. Using an emblem sounds reasonable, though we would have to test whether it's recognizeable at a glance. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90819 --- On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback
> On Jan. 9, 2016, 9:24 nachm., Thomas Pfeiffer wrote: > > Nice idea! > > I'd set the dely until the popup closes again shorter, though. This is just > > a feedback message that things happened as expected, so throwing the popup > > in the user's face for five seconds is too much distraction in that case > > (especially as nothing bad happens if the user misses the feedback). I'd > > just use the standard notification delay (or is that five seconds?). When > > unmounting failed, however, it should stay for five seconds because it's > > important that the user knows that the should not unplug the device. The 5 seconds are for when the dialog is already opened. It does not change the time until it auto-closes again, after which the message disappears anyway. I don't know that duration from the top of me head, though. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review90823 --- On Jan. 9, 2016, 8:15 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126688/ > --- > > (Updated Jan. 9, 2016, 8:15 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > --- > > Instead of showing a detached status bar with the device name, show the > message below the device. > > When removing a device, device notifier will pop up and a "You can now safely > remove this device" message will show up; after 5 seconds the message and the > device will disappear. When trying to unmount a device and it fails, device > notifier will show up with an error message that will stay there until device > notifier is closed or another message appears. > > This review consists of two patches: one for fixing the device notifications > engine's wording (I'm open to better verbalizations) and one for the device > notifier > > > Diffs > - > > applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b > applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 > applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 > dataengines/devicenotifications/ksolidnotify.h fac8cc1 > dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 > > Diff: https://git.reviewboard.kde.org/r/126688/diff/ > > > Testing > --- > > There a still a couple of glitches: > - the layout doesn't properly reset at times (eg. the delegate height doesn't > update) or fails to show certain items (also looks like a Qt bug) > - sometimes the delegates suddenly overlap each other beacuse the section > thing gets confused when the one item is already gone in the model (looks > like a Qt bug) > - the "no devices" heading doesn't know that there's still a pseudo-device > there > - it cannot actually highlight the device that was safely removed (it's no > longer part of the model and thus has no index), we could do a hack for this > though > - the message doesn't disappear reliably or spontaneously re-appears > - depending on your screen dpi you sometimes get a black and white Info icon > but the error thing is always red, there's a smaller variant for the former > but not the latter apparently, also it seems we lack a proper "task done" > icon, Oxygen had one > > > File Attachments > > > Failed to mount > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png > Safely remove > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
