Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-04-18 Thread David Rosca 


> On April 15, 2016, 6:45 p.m., LUIS GUSTAVO BARRETO wrote:
> > src/plasma/corona.cpp, line 179
> > 
> >
> > If you don't call importLayout() the startupCompleted signal never gets 
> > emitted causing a slow startup of Plasma Desktop.

https://bugs.kde.org/show_bug.cgi?id=360777 ?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review94644
---


On March 16, 2016, 11:40 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 16, 2016, 11:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-19 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 16, 2016, 11:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-19 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 16, 2016, 11:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 309c64f5e90453c5253baf19e6c01759e8aa6f83 by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez 


> On March 12, 2016, 8:26 p.m., Marco Martin wrote:
> > src/plasmaquick/appletquickitem.h, line 31
> > 
> >
> > appletquickitem.h is now installed as a public header, <> include 
> > should be fixed somehow

Eh, I'll drop this change from the patch, it wasn't supposed to be part of this.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93455
---


On March 12, 2016, 4 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 4 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93455
---




src/plasmaquick/appletquickitem.h (line 31)


appletquickitem.h is now installed as a public header, <> include should be 
fixed somehow


- Marco Martin


On March 12, 2016, 3 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 3 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 12, 2016, 4 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Properly check if the config is empty.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs (updated)
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93447
---


Ship it!




Ship It!

- Sebastian Kügler


On March 12, 2016, 1:13 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 1:13 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/corona.cpp 5d17550 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/
---

(Updated March 12, 2016, 2:13 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

* Change the test file name to test.qml
* Don't load a layout if it doesn't exist. Otherwise it reports that 
`::startupCompleted()` despite not having any containments.


Repository: plasma-framework


Description
---

In an attempt to make it possible for plasmoid to test themselves in the 
different shells, provide API to exatract the object that will test the 
plasmoid instance.


Diffs (updated)
-

  src/plasma/corona.cpp 5d17550 
  src/plasma/private/packages.cpp a5ba81a 
  src/plasmaquick/appletquickitem.h 4f25f5d 
  src/plasmaquick/appletquickitem.cpp 9242e9e 
  src/plasmaquick/private/appletquickitem_p.h 9c24734 

Diff: https://git.reviewboard.kde.org/r/127345/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93444
---


Ship it!




for me is a ship it, modulo just calling it just "test.qml" as sebas already 
pointed out

- Marco Martin


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin 


> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote:
> > src/plasma/private/packages.cpp, line 46
> > 
> >
> > I'd just go for test.qml or perhaps even autotest.qml

test.qml would be good if the abstract name is just "test" (don't want weird 
inconsistencies as in the past happened with "code" vs "scritps")


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93442
---


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93442
---


Fix it, then Ship it!




Like my other review: if we want this approach, the code is fine and good to go.


src/plasma/private/packages.cpp (line 46)


I'd just go for test.qml or perhaps even autotest.qml


- Sebastian Kügler


On March 12, 2016, 12:29 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 12, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Aleix Pol Gonzalez 


> On March 11, 2016, 11:14 p.m., Marco Martin wrote:
> > src/plasmaquick/appletquickitem.cpp, line 648
> > 
> >
> > who will be using this? from the shell?

Yes, see my patch in plasma-workspace.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93422
---


On March 11, 2016, 9:26 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 11, 2016, 9:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93422
---




src/plasmaquick/appletquickitem.h (line 130)


you don't really need this
http://doc.qt.io/qt-5/qqmlengine.html#qmlEngine



src/plasmaquick/appletquickitem.cpp (line 648)


who will be using this? from the shell?


- Marco Martin


On March 11, 2016, 8:26 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 11, 2016, 8:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-11 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93419
---



I have a rough idea how you want it to work, but to really evaluate the patch, 
I need to understand the bigger picture.

Some smallish issues pointed out inline.


src/plasmaquick/appletquickitem.h (line 31)


unrelated?

(IMO no need to make another patch for it, just checking.)



src/plasmaquick/appletquickitem.h (line 129)


teh mistake!



src/plasmaquick/appletquickitem.cpp (line 652)


{ } also for single lines


- Sebastian Kügler


On March 11, 2016, 8:26 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> ---
> 
> (Updated March 11, 2016, 8:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> In an attempt to make it possible for plasmoid to test themselves in the 
> different shells, provide API to exatract the object that will test the 
> plasmoid instance.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel