Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

[René J . V . Bertin]

On Friday October 28 2016 20:24:10 Martin Gräßlin wrote:
>Am 2016-10-28 19:25, schrieb René J.V. Bertin:

>Sorry, I think there was a misunderstanding. I checked all the variables 
>set by macro_bool_to_01 in ConfigureChecks.cmake. In other files it's 
>not used.

Indeed, and no, that wasn't what I meant :)

Cheers,
René

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

[Martin Gräßlin]

Am 2016-10-28 19:25, schrieb René J.V. Bertin:

On Friday October 28 2016 14:00:54 Martin Graesslin wrote:

Hi,

I wouldn't exclude the possibility that this is old and 
dead/non-functional
code. I just did a git grep for every of the CMake variables se 
through the

macro_bool_to_01 and only found:
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:
target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})


And in ConfigureChecks.cmake, which is the file generating the error
for me in 5.8.2 . It didn't before, which made me think that somehow
cmake picked up the definition elsewhere, in code that has now been
modernised.


Sorry, I think there was a misunderstanding. I checked all the variables 
set by macro_bool_to_01 in ConfigureChecks.cmake. In other files it's 
not used.


Cheers
Martin

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

[René J . V . Bertin]

On Friday October 28 2016 14:00:54 Martin Graesslin wrote:

Hi,

>>I wouldn't exclude the possibility that this is old and dead/non-functional 
>code. I just did a git grep for every of the CMake variables se through the 
>macro_bool_to_01 and only found:
>dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
>dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
>dataengines/mouse/CMakeLists.txt:   
>target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})

And in ConfigureChecks.cmake, which is the file generating the error for me in 
5.8.2 . It didn't before, which made me think that somehow cmake picked up the 
definition elsewhere, in code that has now been modernised.

Cheers,
René

Re: macro_bool_to_01 macro in plasma-workspace/ConfigureChecks.cmake

[Martin Graesslin]

On Friday, October 28, 2016 11:24:35 AM CEST René J.V. Bertin wrote:
> Hi,
> 
> Where exactly is plasma-workspace's build system supposed to find the
> macro_bool_to_01 macro? Apparently it's been obsolete for quite some time
> and it doesn't seem to be provided by any of the listed dependencies (= I
> get a not-found error).

I wouldn't exclude the possibility that this is old and dead/non-functional 
code. I just did a git grep for every of the CMake variables se through the 
macro_bool_to_01 and only found:

dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:if (X11_Xfixes_FOUND)
dataengines/mouse/CMakeLists.txt:   
target_link_libraries(plasma_engine_mouse ${X11_Xfixes_LIB})

and that code while having it in the CMakeLists being used uses in the code
#ifdef HAVE_XFIXES

(which is wrong, should be #if HAVE_XFIXES)

So overall looks rather dead to me.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.