Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-24 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3253
---

Ship it!


- Aaron


On 2009-11-24 12:59:38, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-24 12:59:38)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1052445 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1052445 
>   trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1052445 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1053618 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1053618 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1052445 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1052445 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-24 Thread Jacopo De Simoi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
---

(Updated 2009-11-24 12:59:38.449340)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
---

Do not load single runners if not selected; for now export them only if so, 
this will be dropped when loading-on-the-fly is implemented
this still needs to load them on-the-fly, but it can be easily fixed after 
commit


Summary
---

This is the API needed by the new single Runner mode for krunner (more on 
usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the 
runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in 
RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in 
case the runners need to change their behaviour accordingly (e.g. to _not_ 
discard queries with less than 3 chars)


Diffs (updated)
-

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1052445 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1052445 
  trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1052445 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1053618 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1053618 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1052445 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1052445 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
---


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-21 Thread Jacopo De Simoi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
---

(Updated 2009-11-21 18:49:12.791648)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
---

forgot to add the relevant changes to the private header
Please let me know if the logic is ok (loading selected + singlequerymode at 
startup) or
if I should load SQM runners on the fly despite possibly long initialization 
times (yes I know we're working on that)


Summary
---

This is the API needed by the new single Runner mode for krunner (more on 
usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the 
runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in 
RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in 
case the runners need to change their behaviour accordingly (e.g. to _not_ 
discard queries with less than 3 chars)


Diffs (updated)
-

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1052445 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1052445 
  trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1052445 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1052445 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1052445 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1052445 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1052445 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
---


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-19 Thread Jacopo De Simoi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
---

(Updated 2009-11-20 07:55:33.801723)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
---

updated diff to recent changes in trunk


Summary
---

This is the API needed by the new single Runner mode for krunner (more on 
usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the 
runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in 
RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in 
case the runners need to change their behaviour accordingly (e.g. to _not_ 
discard queries with less than 3 chars)


Diffs (updated)
-

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1050953 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1050953 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1050953 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1050953 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1050953 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1050953 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
---


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
---

(Updated 2009-11-17 17:52:14.417634)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
---

In order for the runner to be exposed by krunner as single runner query mode 
(SRQM) enabled, the relative .desktop file must now provide the 
"SingleRunnerQueryMode" key set to true; this allows the runnerManager to load 
and keep loaded the SRQM-enabled runners even if the user does not want them in 
the main krunner window results. 
A certain amount of bookkeeping has to be done to ensure that everything works 
properly; the implementation attempts to minimize that and minimize the risk of 
breakage.

All previous review comments have been taken into account


Summary
---

This is the API needed by the new single Runner mode for krunner (more on 
usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the 
runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in 
RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in 
case the runners need to change their behaviour accordingly (e.g. to _not_ 
discard queries with less than 3 chars)


Diffs (updated)
-

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1048133 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1050508 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
---


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-17 Thread Jacopo De Simoi 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406
> > 
> >
> > this should probably be setDefaultSyntax, since it doesn't really add 
> > another default syntax. also prevents the need to explain how it works in 
> > the apidox :)
> 
> Jacopo De Simoi wrote:
> well, the correct name should indeed be
> addSyntaxAndSetAsDefault, but I guess it's a little bit too much :)
> 
> Aaron Seigo wrote:
> i think setDefaultSyntax implies it will become part of the syntax bunch; 
> perhaps a note in the apidox that it isn't necessary to to also call 
> addSyntax and a check to ensure it isn't already in the collection might be 
> in order.
> 
> Jacopo De Simoi wrote:
> agreed

Done, (+note in the apidox) 
However checking that the syntax is already in the collection is complicated by 
the fact that we need to define what the operator== means for a syntax;
besides, it should probably be added for addSyntax as well...


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-16 Thread Aaron Seigo 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)
> 
> Aaron Seigo wrote:
> i don't see how it could affect any other users; if they don't call 
> setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
> require purposefully changing the code in the other places it is used to 
> cause problems :)
> 
> Jacopo De Simoi wrote:
> aw, I should really read the whole comment before replying. In fact your 
> comment makes perfect sense
> 
> Jacopo De Simoi wrote:
> I am trying to fix this and now I remember what didn't work without that 
> bool.
> The point is that launchQuery resets() the context, hence it is 
> launchQuery itself that sets the single runner query mode; thus it makes 
> little sense to check RunnerContext::singleRunnerMode(); and I am not sure if 
> assuming that the empty query should always be substituted if a runner is 
> specified would break other apps.
> What should I do then? keep the bool? any alternative solutions?
>

if the runner has set a default syntax, then it should be substituted. if there 
is no default syntax, it doesn't get substituted. in this case, i think it's 
really less a question of what the application using RunnerManager expects and 
more what the AbstractRunner plugin would expect. so yes, i think we can still 
just get rid of that method with the extra bool :)


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-16 Thread Jacopo De Simoi 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)
> 
> Aaron Seigo wrote:
> i don't see how it could affect any other users; if they don't call 
> setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
> require purposefully changing the code in the other places it is used to 
> cause problems :)
> 
> Jacopo De Simoi wrote:
> aw, I should really read the whole comment before replying. In fact your 
> comment makes perfect sense

I am trying to fix this and now I remember what didn't work without that bool.
The point is that launchQuery resets() the context, hence it is launchQuery 
itself that sets the single runner query mode; thus it makes little sense to 
check RunnerContext::singleRunnerMode(); and I am not sure if assuming that the 
empty query should always be substituted if a runner is specified would break 
other apps.
What should I do then? keep the bool? any alternative solutions?


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)
> 
> Aaron Seigo wrote:
> i don't see how it could affect any other users; if they don't call 
> setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
> require purposefully changing the code in the other places it is used to 
> cause problems :)

aw, I should really read the whole comment before replying. In fact your 
comment makes perfect sense 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406
> > 
> >
> > this should probably be setDefaultSyntax, since it doesn't really add 
> > another default syntax. also prevents the need to explain how it works in 
> > the apidox :)
> 
> Jacopo De Simoi wrote:
> well, the correct name should indeed be
> addSyntaxAndSetAsDefault, but I guess it's a little bit too much :)
> 
> Aaron Seigo wrote:
> i think setDefaultSyntax implies it will become part of the syntax bunch; 
> perhaps a note in the apidox that it isn't necessary to to also call 
> addSyntax and a check to ensure it isn't already in the collection might be 
> in order.

agreed


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406
> > 
> >
> > this should probably be setDefaultSyntax, since it doesn't really add 
> > another default syntax. also prevents the need to explain how it works in 
> > the apidox :)
> 
> Jacopo De Simoi wrote:
> well, the correct name should indeed be
> addSyntaxAndSetAsDefault, but I guess it's a little bit too much :)

i think setDefaultSyntax implies it will become part of the syntax bunch; 
perhaps a note in the apidox that it isn't necessary to to also call addSyntax 
and a check to ensure it isn't already in the collection might be in order.


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?
> 
> Jacopo De Simoi wrote:
> In fact it should. I was worried of changing the default behaviour of 
> this method. I was not sure to be able to check that this wouldn't affect any 
> other app using runnermanager (kickoff?)

i don't see how it could affect any other users; if they don't call 
setSingleRunnerMode(true) it behaves exactly as it did before. so it would 
require purposefully changing the code in the other places it is used to cause 
problems :)


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi 


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406
> > 
> >
> > this should probably be setDefaultSyntax, since it doesn't really add 
> > another default syntax. also prevents the need to explain how it works in 
> > the apidox :)

well, the correct name should indeed be
addSyntaxAndSetAsDefault, but I guess it's a little bit too much :)


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnercontext.h, lines 180-181
> > 
> >
> > sounds like something that should take a bool?
> > 
> > also, some extra ws snuck in there :)

agreed


> On 2009-11-12 20:39:42, Aaron Seigo wrote:
> > trunk/KDE/kdelibs/plasma/runnermanager.h, line 149
> > 
> >
> > const bool isn't necessary; in fact, i think this whole method 
> > shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then 
> > replaceEmptyQuery should be implied?

In fact it should. I was worried of changing the default behaviour of this 
method. I was not sure to be able to check that this wouldn't affect any other 
app using runnermanager (kickoff?)


- Jacopo


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3063
---



trunk/KDE/kdelibs/plasma/abstractrunner.h


this should probably be setDefaultSyntax, since it doesn't really add 
another default syntax. also prevents the need to explain how it works in the 
apidox :)



trunk/KDE/kdelibs/plasma/runnercontext.h


sounds like something that should take a bool?

also, some extra ws snuck in there :)



trunk/KDE/kdelibs/plasma/runnermanager.h


const bool isn't necessary; in fact, i think this whole method shouldn't be 
necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery 
should be implied?


- Aaron


On 2009-11-07 20:16:02, Jacopo De Simoi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> ---
> 
> (Updated 2009-11-07 20:16:02)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> ---
> 
> This is the API needed by the new single Runner mode for krunner (more on 
> usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the 
> runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in 
> RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in 
> case the runners need to change their behaviour accordingly (e.g. to _not_ 
> discard queries with less than 3 chars)
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jacopo
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-07 Thread Jacopo De Simoi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
---

Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Summary
---

This is the API needed by the new single Runner mode for krunner (more on 
usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the 
runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in 
RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in 
case the runners need to change their behaviour accordingly (e.g. to _not_ 
discard queries with less than 3 chars)


Diffs
-

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
---


Thanks,

Jacopo

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel