Review Request: Add the -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE option into the CMakeLists.txt

2012-03-24 Thread Giorgos Tsiapaliwkas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104401/
---

Review request for Plasma.


Description
---

Hello,

until now in order to build PMC we needed to add 
-DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE as a cmake option.
This patch fixes the issue.


Diffs
-

  CMakeLists.txt aed58e9 

Diff: http://git.reviewboard.kde.org/r/104401/diff/


Testing
---

It compiles and installs successfully


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add the -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE option into the CMakeLists.txt

2012-03-24 Thread Giorgos Tsiapaliwkas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104401/
---

(Updated March 24, 2012, 9:11 p.m.)


Review request for Plasma.


Description
---

Hello,

until now in order to build PMC we needed to add 
-DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE as a cmake option.
This patch fixes the issue.


Diffs
-

  CMakeLists.txt aed58e9 

Diff: http://git.reviewboard.kde.org/r/104401/diff/


Testing
---

It compiles and installs successfully


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add the -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE option into the CMakeLists.txt

2012-03-24 Thread Shantanu Tushar Jha

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104401/#review11826
---


Hi, thanks for the patch. However PMC now uses QtMultimediaKit from Qt Mobility 
instead of Phonon (for the time being until stuff is stable and merged to 
master) and so for now the patch won't be needed :)

- Shantanu Tushar Jha


On March 24, 2012, 9:11 p.m., Giorgos Tsiapaliwkas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104401/
 ---
 
 (Updated March 24, 2012, 9:11 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 Hello,
 
 until now in order to build PMC we needed to add 
 -DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=TRUE as a cmake option.
 This patch fixes the issue.
 
 
 Diffs
 -
 
   CMakeLists.txt aed58e9 
 
 Diff: http://git.reviewboard.kde.org/r/104401/diff/
 
 
 Testing
 ---
 
 It compiles and installs successfully
 
 
 Thanks,
 
 Giorgos Tsiapaliwkas
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel