Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/ --- Review request for Plasma. Description --- When using the keyboard to adjust the slider use the same animation for the groove (the blue line showing amount) and the drag handle. This fixes a bug in which the bar would move then the handle would animate to catch up. In the same patch (and different commit) fix a bug where the value would not be changed whilst dragging, only when released. This has caused issues in the battery applet where the brightness cannot be seen and has bugs reported. Diffs - plasma/declarativeimports/plasmacomponents/qml/Slider.qml d8b66db Diff: http://git.reviewboard.kde.org/r/105236/diff/ Testing --- Tested on battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/#review14708 --- makes sense, the slider background should follow the handle otherwise you can see the man behind the curtain ;) plasma/declarativeimports/plasmacomponents/qml/Slider.qml http://git.reviewboard.kde.org/r/105236/#comment11614 whitespace ;) - Marco Martin On June 13, 2012, 8:09 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/ --- (Updated June 13, 2012, 8:09 a.m.) Review request for Plasma. Description --- When using the keyboard to adjust the slider use the same animation for the groove (the blue line showing amount) and the drag handle. This fixes a bug in which the bar would move then the handle would animate to catch up. In the same patch (and different commit) fix a bug where the value would not be changed whilst dragging, only when released. This has caused issues in the battery applet where the brightness cannot be seen and has bugs reported. Diffs - plasma/declarativeimports/plasmacomponents/qml/Slider.qml d8b66db Diff: http://git.reviewboard.kde.org/r/105236/diff/ Testing --- Tested on battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/#review14709 --- Ship it! - Marco Martin On June 13, 2012, 8:09 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/ --- (Updated June 13, 2012, 8:09 a.m.) Review request for Plasma. Description --- When using the keyboard to adjust the slider use the same animation for the groove (the blue line showing amount) and the drag handle. This fixes a bug in which the bar would move then the handle would animate to catch up. In the same patch (and different commit) fix a bug where the value would not be changed whilst dragging, only when released. This has caused issues in the battery applet where the brightness cannot be seen and has bugs reported. Diffs - plasma/declarativeimports/plasmacomponents/qml/Slider.qml d8b66db Diff: http://git.reviewboard.kde.org/r/105236/diff/ Testing --- Tested on battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix value not being updated when dragging slider, also fix animation when using keys.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/#review14711 --- This review has been submitted with commit 7ce67a27fcfcb888a98fe3f7cf32ddb96ee8d702 by David Edmundson to branch master. - Commit Hook On June 13, 2012, 8:09 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105236/ --- (Updated June 13, 2012, 8:09 a.m.) Review request for Plasma. Description --- When using the keyboard to adjust the slider use the same animation for the groove (the blue line showing amount) and the drag handle. This fixes a bug in which the bar would move then the handle would animate to catch up. In the same patch (and different commit) fix a bug where the value would not be changed whilst dragging, only when released. This has caused issues in the battery applet where the brightness cannot be seen and has bugs reported. Diffs - plasma/declarativeimports/plasmacomponents/qml/Slider.qml d8b66db Diff: http://git.reviewboard.kde.org/r/105236/diff/ Testing --- Tested on battery plasmoid. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
