Re: Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/#review11334 --- This review has been submitted with commit 072cc784c614614e177efa2b6aebe1ba1ab02de6 by Shantanu Tushar to branch master. - Commit Hook On March 11, 2012, 4:51 p.m., Shantanu Tushar Jha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104229/ > --- > > (Updated March 11, 2012, 4:51 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > This patch makes two additions- > 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property > to make it configurable > 2. KIO Thumbnailer uses a default set of plugins (from global config, which > can't be set from PA) which doesn't include video thumbnailers for example. > This makes metadatamodel fail when its asked for a thumbnail for a video > file. This patch explicitly tells KIO to use all plugins. > > > Diffs > - > > components/metadatamodel/metadatamodel.h 85750fe > components/metadatamodel/metadatamodel.cpp 74ad09c > > Diff: http://git.reviewboard.kde.org/r/104229/diff/ > > > Testing > --- > > Both features work when tested from QML and don't seem to have any > side-effects. > > > Thanks, > > Shantanu Tushar Jha > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/#review11327 --- Ship it! Ship It! - Marco Martin On March 11, 2012, 4:51 p.m., Shantanu Tushar Jha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104229/ > --- > > (Updated March 11, 2012, 4:51 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > This patch makes two additions- > 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property > to make it configurable > 2. KIO Thumbnailer uses a default set of plugins (from global config, which > can't be set from PA) which doesn't include video thumbnailers for example. > This makes metadatamodel fail when its asked for a thumbnail for a video > file. This patch explicitly tells KIO to use all plugins. > > > Diffs > - > > components/metadatamodel/metadatamodel.h 85750fe > components/metadatamodel/metadatamodel.cpp 74ad09c > > Diff: http://git.reviewboard.kde.org/r/104229/diff/ > > > Testing > --- > > Both features work when tested from QML and don't seem to have any > side-effects. > > > Thanks, > > Shantanu Tushar Jha > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
> On March 11, 2012, 10:36 p.m., Marco Martin wrote: > > looks fine, but i would prefer the thumbnail plugins to be configurable if > > more than images are going to be used > > Shantanu Tushar Jha wrote: > I didn't understand the "more than images are going to be used" part :( > > (KIO includes three plugins by default "directorythumbnail", > "imagethumbnail", "jpegthumbnail") i mean, support for different types of thumbnail plugins configurable. but since they are generated in a quite lazy way (no preview is generated until asked for) you can go for it, then we'll see if it impacts performancein any way - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/#review11302 --- On March 11, 2012, 4:51 p.m., Shantanu Tushar Jha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104229/ > --- > > (Updated March 11, 2012, 4:51 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > This patch makes two additions- > 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property > to make it configurable > 2. KIO Thumbnailer uses a default set of plugins (from global config, which > can't be set from PA) which doesn't include video thumbnailers for example. > This makes metadatamodel fail when its asked for a thumbnail for a video > file. This patch explicitly tells KIO to use all plugins. > > > Diffs > - > > components/metadatamodel/metadatamodel.h 85750fe > components/metadatamodel/metadatamodel.cpp 74ad09c > > Diff: http://git.reviewboard.kde.org/r/104229/diff/ > > > Testing > --- > > Both features work when tested from QML and don't seem to have any > side-effects. > > > Thanks, > > Shantanu Tushar Jha > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
> On March 11, 2012, 10:36 p.m., Marco Martin wrote: > > looks fine, but i would prefer the thumbnail plugins to be configurable if > > more than images are going to be used I didn't understand the "more than images are going to be used" part :( (KIO includes three plugins by default "directorythumbnail", "imagethumbnail", "jpegthumbnail") - Shantanu Tushar --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/#review11302 --- On March 11, 2012, 4:51 p.m., Shantanu Tushar Jha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104229/ > --- > > (Updated March 11, 2012, 4:51 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > This patch makes two additions- > 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property > to make it configurable > 2. KIO Thumbnailer uses a default set of plugins (from global config, which > can't be set from PA) which doesn't include video thumbnailers for example. > This makes metadatamodel fail when its asked for a thumbnail for a video > file. This patch explicitly tells KIO to use all plugins. > > > Diffs > - > > components/metadatamodel/metadatamodel.h 85750fe > components/metadatamodel/metadatamodel.cpp 74ad09c > > Diff: http://git.reviewboard.kde.org/r/104229/diff/ > > > Testing > --- > > Both features work when tested from QML and don't seem to have any > side-effects. > > > Thanks, > > Shantanu Tushar Jha > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/#review11302 --- looks fine, but i would prefer the thumbnail plugins to be configurable if more than images are going to be used - Marco Martin On March 11, 2012, 4:51 p.m., Shantanu Tushar Jha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104229/ > --- > > (Updated March 11, 2012, 4:51 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > --- > > This patch makes two additions- > 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property > to make it configurable > 2. KIO Thumbnailer uses a default set of plugins (from global config, which > can't be set from PA) which doesn't include video thumbnailers for example. > This makes metadatamodel fail when its asked for a thumbnail for a video > file. This patch explicitly tells KIO to use all plugins. > > > Diffs > - > > components/metadatamodel/metadatamodel.h 85750fe > components/metadatamodel/metadatamodel.cpp 74ad09c > > Diff: http://git.reviewboard.kde.org/r/104229/diff/ > > > Testing > --- > > Both features work when tested from QML and don't seem to have any > side-effects. > > > Thanks, > > Shantanu Tushar Jha > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/ --- Review request for Plasma and Marco Martin. Description --- This patch makes two additions- 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property to make it configurable 2. KIO Thumbnailer uses a default set of plugins (from global config, which can't be set from PA) which doesn't include video thumbnailers for example. This makes metadatamodel fail when its asked for a thumbnail for a video file. This patch explicitly tells KIO to use all plugins. Diffs - components/metadatamodel/metadatamodel.h 85750fe components/metadatamodel/metadatamodel.cpp 74ad09c Diff: http://git.reviewboard.kde.org/r/104229/diff/ Testing --- Both features work when tested from QML and don't seem to have any side-effects. Thanks, Shantanu Tushar Jha ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Make thumbnail size configurable and tell KIO to use all thumbnailer plguins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104229/ --- Review request for Plasma and Marco Martin. Description --- This patch makes two additions- 1. Thumbnail size is hardcoded into metadatamodel, this patch adds a property to make it configurable 2. KIO Thumbnailer uses a default set of plugins (from global config, which can't be set from PA) which doesn't include video thumbnailers for example. This makes metadatamodel fail when its asked for a thumbnail for a video file. This patch explicitly tells KIO to use all plugins. Diffs - components/metadatamodel/metadatamodel.h 85750fe components/metadatamodel/metadatamodel.cpp 74ad09c Diff: http://git.reviewboard.kde.org/r/104229/diff/ Testing --- Both features work when tested from QML and don't seem to have any side-effects. Thanks, Shantanu Tushar Jha ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
