Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-13 18:25:55.173503) Review request for Plasma and Anne-Marie Mahfouf. Changes --- I have removed the debug statements and have cleaned the code. Now, I am working on implementation of a ui , may be a tab which would call the chime() function for chiming of sounds Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-13 19:17:35.920939) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug 232004. https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9214 --- A few remarks after a quick look: - you should not leave the debug output, too much noise for reading the diff, please remove and repost new diff - you should not modify indentation - correct in new diff - the Phonon headers do not need to be included twice - where is the pig.wav from? It should be installed and read from global installation with KStandardDirs. And the name should be changed! - Anne-Marie On 2010-12-12 19:20:12, Sunny Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 19:20:12) Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9213 --- could be a good idea (even if i'm not sure this should be in the default clock, maybe could be worth its own) if it's going in it should wait svn reopens for 4.7 development, or go into git when the migrtion is done. right now there are a couple of (easy to fix) issues: /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h http://svn.reviewboard.kde.org/r/6108/#comment10084 m_ prefix /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp http://svn.reviewboard.kde.org/r/6108/#comment10086 objects shouldn't be created in paintinterface, would impact fluidity and pile up without being deleted (only at applet destruction) only a global object should exist. /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp http://svn.reviewboard.kde.org/r/6108/#comment10085 this debug output should become more sober in the final version ;) - Marco On 2010-12-12 19:20:12, Sunny Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 19:20:12) Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9215 --- This is wish https://bugs.kde.org/show_bug.cgi?id=232004 I think it should be in the base clock widget, I'm sure there will be people wanting chimes from the standard panel clock as well, so long as they are off by default and don't consume any resources. See http://websvn.kde.org/trunk/KDE/kdebase/workspace/libs/plasmaclock/, probably done something like ClockApplet::speakTime(const QTime time). You will need to allow users to configure multiple chimes, at least the 4 quarters but possibly as many as they like at any time they like, and allow them to select a different sound for each chime. Depending on the size it takes, put the config ui either into a new tab called Chimes, or into General which is the only current tab with any space left. I wonder where we can get Free wav's for Westminster Chimes? :-) - John On 2010-12-12 19:20:12, Sunny Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 19:20:12) Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
On 2010-12-12 20:27:41, John Layt wrote: This is wish https://bugs.kde.org/show_bug.cgi?id=232004 I think it should be in the base clock widget, I'm sure there will be people wanting chimes from the standard panel clock as well, so long as they are off by default and don't consume any resources. See http://websvn.kde.org/trunk/KDE/kdebase/workspace/libs/plasmaclock/, probably done something like ClockApplet::speakTime(const QTime time). You will need to allow users to configure multiple chimes, at least the 4 quarters but possibly as many as they like at any time they like, and allow them to select a different sound for each chime. Depending on the size it takes, put the config ui either into a new tab called Chimes, or into General which is the only current tab with any space left. I wonder where we can get Free wav's for Westminster Chimes? :-) Oh, and you'll need striking the hours as well, i.e. at 8pm you play a Bong sound 8 times, again able to be turned on/off and choose the sound. - John --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/#review9215 --- On 2010-12-12 19:20:12, Sunny Sharma wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 19:20:12) Review request for Plasma, Aaron Seigo and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6108/ --- (Updated 2010-12-12 23:01:41.350300) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Hello Everybody, i have implemented the chiming of the analog clock every hour.though i have hard coded it and it would only chime every hour. and not for 45 mins. Presently I am working on the development of a ui which would allow the user to set the clock to chime according to the choice of the user. thanks, sunny_slls This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004. https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004 Diffs - /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1203585 /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1203585 Diff: http://svn.reviewboard.kde.org/r/6108/diff Testing --- Thanks, Sunny ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: The clock applet chiming per hour, half-hour and quarter hour
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6108/#review9223
---
as others noted, the debug should be removed for the final patch; but we're not
quite there yet :)
this code really belongs, as John Layt noted, in libplasmaclock. in
kdebase/workspace/libs/plasmaclock/clockapplet.cpp there is a updateClockApplet
method that now calls speakTime. this feature should be handled similarly,
perhaps with a chimeTime() method.
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt
http://svn.reviewboard.kde.org/r/6108/#comment10094
shouldn't be in the final patch :)
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp
http://svn.reviewboard.kde.org/r/6108/#comment10095
whitespace: } else {
- Aaron
On 2010-12-12 23:01:41, Sunny Sharma wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6108/
---
(Updated 2010-12-12 23:01:41)
Review request for Plasma and Anne-Marie Mahfouf.
Summary
---
Hello Everybody,
i have implemented the chiming of the analog clock every hour.though i have
hard coded it and it would only chime every hour. and not for 45 mins.
Presently I am working on the development of a ui which would allow the user
to set the clock to chime according to the choice of the user.
thanks,
sunny_slls
This addresses bug https://bugs.kde.org/show_bug.cgi?id=232004.
https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=232004
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/CMakeLists.txt
1203585
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h
1203585
/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp
1203585
Diff: http://svn.reviewboard.kde.org/r/6108/diff
Testing
---
Thanks,
Sunny
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
