Re: Review Request: add keyboard nav to konsoleprofiles widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- Ship it! Ship It! - Shaun Reich On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
On July 28, 2012, 4:06 p.m., Shaun Reich wrote: Ship It! Looks good. Think you could also propagate this to the Kate and Konsole widgets? - Shaun --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
On July 28, 2012, 4:06 p.m., Shaun Reich wrote: Ship It! Shaun Reich wrote: Looks good. Think you could also propagate this to the Kate and Konsole widgets? Greg T wrote: I can also add this to konqprofiles. I don't know what konsole widgets you are referring to. Oops. I meant the Kate widget as well as the KDevelop widget. - Shaun --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: add keyboard nav to konsoleprofiles widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16575 --- This review has been submitted with commit de2c5056f8780f223b831d01310d5c700fbeed5c by Gregor Tätzner to branch master. - Commit Hook On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16576 --- This review has been submitted with commit d0cc3bde727555ca31e1b36b3d7c707e990cab1b by Gregor Tätzner to branch KDE/4.9. - Commit Hook On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: add keyboard nav to konsoleprofiles widget
On July 28, 2012, 4:06 p.m., Shaun Reich wrote: Ship It! Shaun Reich wrote: Looks good. Think you could also propagate this to the Kate and Konsole widgets? I can also add this to konqprofiles. I don't know what konsole widgets you are referring to. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- On July 28, 2012, 11:24 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/ --- (Updated July 28, 2012, 11:24 a.m.) Review request for Plasma and Shaun Reich. Description --- adds keyboard navigation. up/down arrow key to select item, Enter to open it This addresses bug 303297. http://bugs.kde.org/show_bug.cgi?id=303297 Diffs - applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml c4c76927208a40c586a93e60a7c1b71ffc4e23b8 Diff: http://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
