Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated May 27, 2013, 6:14 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, Martin Gräßlin, and Marco Martin. Description --- It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17. Didn't try xfce nor mutter. Technically: I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one is sending events to the root and this also seems the case for all other WMs (at least everything now starts to cause the signal to be emitted) The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there'll be some X11 event processing on top that eats away the client messages. So this one can be scratched from the patch, the KWindowSystem issue remains. This addresses bug 179042. http://bugs.kde.org/show_bug.cgi?id=179042 Diffs - kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 Diff: http://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary File Attachments testcase http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review33239 --- This review has been submitted with commit 73fa526cd5541e74c3e992e9fcb0278efaaa5366 by Thomas Lübking to branch KDE/4.10. - Commit Hook On March 23, 2013, 8:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 8:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review33146 --- Ship it! Ship It! - Aaron J. Seigo On March 23, 2013, 8:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 8:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
> On May 3, 2013, 6:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? > > Ralf Jung wrote: > Thomas fixed some existing issues which were uncovered by this patch, see > https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no > other issues are known. > > Aaron J. Seigo wrote: > Yes, if we can please get this in that would be great. Personally, i'm waiting for sth. between a "ship it" and "i feel in charge to decide this and i decide that if you say it works and are willing to take responsibility for this patch, feel free to commit it" from some regular kdelibs developer. This is more a commit policy worry (workaround patch, frozen libs) than a technical one from my side. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review31963 --- On March 23, 2013, 8:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 8:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
> On May 3, 2013, 6:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? > > Ralf Jung wrote: > Thomas fixed some existing issues which were uncovered by this patch, see > https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no > other issues are known. Yes, if we can please get this in that would be great. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review31963 --- On March 23, 2013, 8:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 8:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
> On May 3, 2013, 8:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? Thomas fixed some existing issues which were uncovered by this patch, see https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no other issues are known. - Ralf --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review31963 --- On March 23, 2013, 9:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 9:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review31963 --- any news on this? Martin, what do you think about it? - Marco Martin On March 23, 2013, 8:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 8:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review30836 --- The plasma bug about not noticing composite changes is hitting me regularly, now that I make use the suspend-compositing-window-hint feature. It's quite annoying as I often have to restart plamsa and toggle compositing two or three times until it finally gets things right again. This patch fixes the issue fine for me. Would it be possible for some core kdelibs developer to have a look at this, so that this 4-year-old bug can finally be resolved? It'd be a shame if KDE 4.11 would ship without this patch. - Ralf Jung On March 23, 2013, 9:06 p.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated March 23, 2013, 9:06 p.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated March 23, 2013, 8:06 p.m.) Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, Martin Gräßlin, and Marco Martin. Description --- It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17. Didn't try xfce nor mutter. Technically: I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one is sending events to the root and this also seems the case for all other WMs (at least everything now starts to cause the signal to be emitted) The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there'll be some X11 event processing on top that eats away the client messages. So this one can be scratched from the patch, the KWindowSystem issue remains. This addresses bug 179042. http://bugs.kde.org/show_bug.cgi?id=179042 Diffs - kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 Diff: http://git.reviewboard.kde.org/r/107983/diff/ Testing --- see summary File Attachments testcase http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp Thanks, Thomas Lübking ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review29757 --- Could this patch be re-considered for 4.11? It reliably fixes the old and annoying issue of Plasma picking the wrong theme. - Ralf Jung On Jan. 9, 2013, 3 a.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated Jan. 9, 2013, 3 a.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
> On Jan. 12, 2013, 5:25 p.m., Xuetian Weng wrote: > > After several days test, so far no problem here. Ok, everyone. Thu 17. Jan 00:59:00 CET 2013 : KDE SC 4.10 Tagging Freeze for Release Candidate 3 If we want such workaround in 4.10 I suggest to push it before that date, i'll not push it after. Since it's not clear whether a fix can be in Qt 4.8.5 at all or when that will be released and whether distros will have it with KDE 4.10 I propose to have the workaround now, seek to get a fix into Qt and as soon as the fix is there, qVersion() the workaoround away. I will however *not* push into kdelibs w/o any comment of some profiled kdelibs developer in this regard. - Thomas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25307 --- On Jan. 9, 2013, 2 a.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated Jan. 9, 2013, 2 a.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25307 --- After several days test, so far no problem here. - Xuetian Weng On Jan. 9, 2013, 2 a.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107983/ > --- > > (Updated Jan. 9, 2013, 2 a.m.) > > > Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Fredrik Höglund, > Martin Gräßlin, and Marco Martin. > > > Description > --- > > It works fine here (tested so far KWindowSystem signal, KSelectionWatcher > only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" > and e17. > Didn't try xfce nor mutter. > > Technically: > I do not at all understand why KWindowSystem is *not* watching the root > window - KSelectionOwner for one is sending events to the root and this also > seems the case for all other WMs (at least everything now starts to cause the > signal to be emitted) > > The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner > testcase), there'll be some X11 event processing on top that eats away the > client messages. > So this one can be scratched from the patch, the KWindowSystem issue remains. > > > This addresses bug 179042. > http://bugs.kde.org/show_bug.cgi?id=179042 > > > Diffs > - > > kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 > > Diff: http://git.reviewboard.kde.org/r/107983/diff/ > > > Testing > --- > > see summary > > > File Attachments > > > testcase > > http://git.reviewboard.kde.org/media/uploaded/files/2013/01/04/selectionwatcher.cpp > > > Thanks, > > Thomas Lübking > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
