Re: Review Request 109712: Make it possible to use action groups with QMenuItem

2013-03-26 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109712/#review29911
---

Ship it!


Ship It!

- Aaron J. Seigo


On March 25, 2013, 7:24 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109712/
 ---
 
 (Updated March 25, 2013, 7:24 p.m.)
 
 
 Review request for Plasma.
 
 
 Description
 ---
 
 Makes it possible to use the setActionGroup method. It's interesting in case 
 we are displaying options in a menu, since this way we can offer a more 
 appropriate UI.
 
 
 Diffs
 -
 
   plasma/declarativeimports/core/corebindingsplugin.cpp 169fd35 
   plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 
   plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d 
 
 Diff: http://git.reviewboard.kde.org/r/109712/diff/
 
 
 Testing
 ---
 
 I have some code using it locally in muon. It works fine.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 109712: Make it possible to use action groups with QMenuItem

2013-03-26 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109712/
---

(Updated March 26, 2013, 8 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Description
---

Makes it possible to use the setActionGroup method. It's interesting in case we 
are displaying options in a menu, since this way we can offer a more 
appropriate UI.


Diffs
-

  plasma/declarativeimports/core/corebindingsplugin.cpp 169fd35 
  plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 
  plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d 

Diff: http://git.reviewboard.kde.org/r/109712/diff/


Testing
---

I have some code using it locally in muon. It works fine.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 109712: Make it possible to use action groups with QMenuItem

2013-03-25 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109712/
---

Review request for Plasma.


Description
---

Makes it possible to use the setActionGroup method. It's interesting in case we 
are displaying options in a menu, since this way we can offer a more 
appropriate UI.


Diffs
-

  plasma/declarativeimports/core/corebindingsplugin.cpp 169fd35 
  plasma/declarativeimports/plasmacomponents/qmenuitem.h 0f43418 
  plasma/declarativeimports/plasmacomponents/qmenuitem.cpp e8d590d 

Diff: http://git.reviewboard.kde.org/r/109712/diff/


Testing
---

I have some code using it locally in muon. It works fine.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel