Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/ --- Review request for Plasma and Marco Martin. Description --- Fix crash in SortFilterModel::mapRowFromSource() It was not using the correct model to get the source index from the row. Diffs - plasma/declarativeimports/core/datamodel.cpp d257e5e5e902c9cfbe8ea46e4914d9fd64ab96ce plasma/declarativeimports/core/tests/sortfiltermodeltest.h 653c001776fc7e4ba41c27460ade385fc98d1b4a plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp 7e7ee795ec86e2c7e002819cb43ce4a24298ae41 Diff: http://git.reviewboard.kde.org/r/109946/diff/ Testing --- Added unit-tests for mapRowFromSource() and mapRowToSource() to verify they work correctly. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/#review30842 --- Ship it! Ship It! - Marco Martin On April 10, 2013, 1:32 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/ --- (Updated April 10, 2013, 1:32 p.m.) Review request for Plasma and Marco Martin. Description --- Fix crash in SortFilterModel::mapRowFromSource() It was not using the correct model to get the source index from the row. Diffs - plasma/declarativeimports/core/datamodel.cpp d257e5e5e902c9cfbe8ea46e4914d9fd64ab96ce plasma/declarativeimports/core/tests/sortfiltermodeltest.h 653c001776fc7e4ba41c27460ade385fc98d1b4a plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp 7e7ee795ec86e2c7e002819cb43ce4a24298ae41 Diff: http://git.reviewboard.kde.org/r/109946/diff/ Testing --- Added unit-tests for mapRowFromSource() and mapRowToSource() to verify they work correctly. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/#review30843 --- This review has been submitted with commit 3c0cd532170d04221c8cbeda830a9f67f5ea3d27 by Aurélien Gâteau to branch KDE/4.10. - Commit Hook On April 10, 2013, 1:32 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/ --- (Updated April 10, 2013, 1:32 p.m.) Review request for Plasma and Marco Martin. Description --- Fix crash in SortFilterModel::mapRowFromSource() It was not using the correct model to get the source index from the row. Diffs - plasma/declarativeimports/core/datamodel.cpp d257e5e5e902c9cfbe8ea46e4914d9fd64ab96ce plasma/declarativeimports/core/tests/sortfiltermodeltest.h 653c001776fc7e4ba41c27460ade385fc98d1b4a plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp 7e7ee795ec86e2c7e002819cb43ce4a24298ae41 Diff: http://git.reviewboard.kde.org/r/109946/diff/ Testing --- Added unit-tests for mapRowFromSource() and mapRowToSource() to verify they work correctly. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/#review30844 --- This review has been submitted with commit 39de2a637c3b6ac5fb33849ccaa05a7fdd070915 by Sebastian Kügler to branch master. - Commit Hook On April 10, 2013, 2:17 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109946/ --- (Updated April 10, 2013, 2:17 p.m.) Review request for Plasma and Marco Martin. Description --- Fix crash in SortFilterModel::mapRowFromSource() It was not using the correct model to get the source index from the row. Diffs - plasma/declarativeimports/core/datamodel.cpp d257e5e5e902c9cfbe8ea46e4914d9fd64ab96ce plasma/declarativeimports/core/tests/sortfiltermodeltest.h 653c001776fc7e4ba41c27460ade385fc98d1b4a plasma/declarativeimports/core/tests/sortfiltermodeltest.cpp 7e7ee795ec86e2c7e002819cb43ce4a24298ae41 Diff: http://git.reviewboard.kde.org/r/109946/diff/ Testing --- Added unit-tests for mapRowFromSource() and mapRowToSource() to verify they work correctly. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
