Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32643 --- Ship it! Ship It! - Aaron J. Seigo On May 15, 2013, 2:50 p.m., Michał Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 2:50 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 plasma/tests/configloadertest.h ed5a32c plasma/tests/configloadertest.cpp 6737cae plasma/tests/configloadertest.xml 13ccd32 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Compiles, unit test passes (assuming that it was done correctly ;-)). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32649 --- This review has been submitted with commit 72db566f4bf40b79aca69a31e3f514bc7c771628 by Michał Dutkiewicz to branch master. - Commit Hook On May 15, 2013, 2:50 p.m., Michał Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 2:50 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 plasma/tests/configloadertest.h ed5a32c plasma/tests/configloadertest.cpp 6737cae plasma/tests/configloadertest.xml 13ccd32 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Compiles, unit test passes (assuming that it was done correctly ;-)). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 16, 2013, 3:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 plasma/tests/configloadertest.h ed5a32c plasma/tests/configloadertest.cpp 6737cae plasma/tests/configloadertest.xml 13ccd32 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Compiles, unit test passes (assuming that it was done correctly ;-)). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 9:47 a.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Changes --- Removed first part, it's not possible to do it that way (Qt documentation was misleading). Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs (updated) - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing (updated) --- Compiles, not tested yet. Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32568 --- This version compiles! :) Progress.. Please add a test case to tests/configloader.cpp to confirm that this works and then it may be committed. Thanks! - Aaron J. Seigo On May 15, 2013, 7:47 a.m., Michał Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 15, 2013, 7:47 a.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Compiles, not tested yet. Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Failed to compile kdelibs due to unrelated errors (even before applying patch...). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32521 --- plasma/configloader.cpp http://git.reviewboard.kde.org/r/110427/#comment24203 '/' but then ',' which is it (and what color format saves like that?) - Aaron J. Seigo On May 14, 2013, 6:19 p.m., Michał Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 14, 2013, 6:19 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Failed to compile kdelibs due to unrelated errors (even before applying patch...). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 14, 2013, 8:55 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Changes --- Fix character. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs (updated) - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Failed to compile kdelibs due to unrelated errors (even before applying patch...). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
On May 14, 2013, 8:50 p.m., Aaron J. Seigo wrote: plasma/configloader.cpp, lines 204-205 http://git.reviewboard.kde.org/r/110427/diff/1/?file=143707#file143707line204 '/' but then ',' which is it (and what color format saves like that?) True, I have no idea how it got misplaced, it was correct in original code (standalone one). - Michał --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32521 --- On May 14, 2013, 8:55 p.m., Michał Dutkiewicz wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 14, 2013, 8:55 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --- This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504). Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup). This addresses bug 318504. http://bugs.kde.org/show_bug.cgi?id=318504 Diffs - plasma/configloader.cpp 5c67474 Diff: http://git.reviewboard.kde.org/r/110427/diff/ Testing --- Failed to compile kdelibs due to unrelated errors (even before applying patch...). Thanks, Michał Dutkiewicz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
