Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111849/ --- (Updated July 29, 2014, 12:57 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kde-workspace Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: https://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! File Attachments patch https://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch another patch, use custom config file. https://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch screenshot https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote: > > * The patch is not correctly submitted, it's submitted as screenshot, not > > as patch, that makes it impossible to review > > * You didn't attach a screenshot of the UI > > * Checking wether a patch applies is not testing it > > * The clock's config is not the right place for this, it should rather be a > > global calendar setting > > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which > > this patch is not about) > > > > Please read and address my comments more carefully. > > Hu Zheng wrote: > If I submit it as a patch, it will need a Parent Diff, which I don't have > in fact. > The screenshot is added! > You can see the new patch file, it changed to use custom config file. The parent diff is optional. Please also address my other comments. - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/#review38189 --- On Aug. 24, 2013, 7:46 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111849/ > --- > > (Updated Aug. 24, 2013, 7:46 a.m.) > > > Review request for Plasma. > > > Description > --- > > In normal case, the first week is the first week in the year, but the > teachers may want to custom the first week, for example, make the 8th week as > the first week, then the 9th week will be the second week, and so on. Then > the teacher can easily do their work as a custom teaching period! > > > Diffs > - > > > Diff: http://git.reviewboard.kde.org/r/111849/diff/ > > > Testing > --- > > cd kde-workspace-4.10.5/libs/plasmaclock > patch -p1 < customfirstweek.patch > > The save configuration codes are not very beautiful, but it works fine! > > > File Attachments > > > patch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch > another patch, use custom config file. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch > screenshot > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png > > > Thanks, > > Hu Zheng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/ --- (Updated Aug. 24, 2013, 7:46 a.m.) Review request for Plasma. Changes --- Screenshot. Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: http://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! File Attachments (updated) patch http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch another patch, use custom config file. http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch screenshot http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote: > > * The patch is not correctly submitted, it's submitted as screenshot, not > > as patch, that makes it impossible to review > > * You didn't attach a screenshot of the UI > > * Checking wether a patch applies is not testing it > > * The clock's config is not the right place for this, it should rather be a > > global calendar setting > > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which > > this patch is not about) > > > > Please read and address my comments more carefully. If I submit it as a patch, it will need a Parent Diff, which I don't have in fact. The screenshot is added! You can see the new patch file, it changed to use custom config file. - Hu --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/#review38189 --- On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111849/ > --- > > (Updated Aug. 20, 2013, 4:37 a.m.) > > > Review request for Plasma. > > > Description > --- > > In normal case, the first week is the first week in the year, but the > teachers may want to custom the first week, for example, make the 8th week as > the first week, then the 9th week will be the second week, and so on. Then > the teacher can easily do their work as a custom teaching period! > > > Diffs > - > > > Diff: http://git.reviewboard.kde.org/r/111849/diff/ > > > Testing > --- > > cd kde-workspace-4.10.5/libs/plasmaclock > patch -p1 < customfirstweek.patch > > The save configuration codes are not very beautiful, but it works fine! > > > File Attachments > > > patch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch > another patch, use custom config file. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch > > > Thanks, > > Hu Zheng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
> On Aug. 20, 2013, 9 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > isn't this duplicating the functionality in system settings ? locale ? > > country/region & language ? calendar ? first day of the week? No, them are different function! - Hu --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/#review38188 --- On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111849/ > --- > > (Updated Aug. 20, 2013, 4:37 a.m.) > > > Review request for Plasma. > > > Description > --- > > In normal case, the first week is the first week in the year, but the > teachers may want to custom the first week, for example, make the 8th week as > the first week, then the 9th week will be the second week, and so on. Then > the teacher can easily do their work as a custom teaching period! > > > Diffs > - > > > Diff: http://git.reviewboard.kde.org/r/111849/diff/ > > > Testing > --- > > cd kde-workspace-4.10.5/libs/plasmaclock > patch -p1 < customfirstweek.patch > > The save configuration codes are not very beautiful, but it works fine! > > > File Attachments > > > patch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch > another patch, use custom config file. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch > > > Thanks, > > Hu Zheng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/#review38189 --- * The patch is not correctly submitted, it's submitted as screenshot, not as patch, that makes it impossible to review * You didn't attach a screenshot of the UI * Checking wether a patch applies is not testing it * The clock's config is not the right place for this, it should rather be a global calendar setting * kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not about) Please read and address my comments more carefully. - Sebastian Kügler On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111849/ > --- > > (Updated Aug. 20, 2013, 4:37 a.m.) > > > Review request for Plasma. > > > Description > --- > > In normal case, the first week is the first week in the year, but the > teachers may want to custom the first week, for example, make the 8th week as > the first week, then the 9th week will be the second week, and so on. Then > the teacher can easily do their work as a custom teaching period! > > > Diffs > - > > > Diff: http://git.reviewboard.kde.org/r/111849/diff/ > > > Testing > --- > > cd kde-workspace-4.10.5/libs/plasmaclock > patch -p1 < customfirstweek.patch > > The save configuration codes are not very beautiful, but it works fine! > > > File Attachments > > > patch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch > another patch, use custom config file. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch > > > Thanks, > > Hu Zheng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/#review38188 --- isn't this duplicating the functionality in system settings → locale → country/region & language → calendar → first day of the week? - Martin Tobias Holmedahl Sandsmark On Aug. 20, 2013, 4:37 a.m., Hu Zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111849/ > --- > > (Updated Aug. 20, 2013, 4:37 a.m.) > > > Review request for Plasma. > > > Description > --- > > In normal case, the first week is the first week in the year, but the > teachers may want to custom the first week, for example, make the 8th week as > the first week, then the 9th week will be the second week, and so on. Then > the teacher can easily do their work as a custom teaching period! > > > Diffs > - > > > Diff: http://git.reviewboard.kde.org/r/111849/diff/ > > > Testing > --- > > cd kde-workspace-4.10.5/libs/plasmaclock > patch -p1 < customfirstweek.patch > > The save configuration codes are not very beautiful, but it works fine! > > > File Attachments > > > patch > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch > another patch, use custom config file. > > http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch > > > Thanks, > > Hu Zheng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/ --- (Updated Aug. 20, 2013, 4:37 a.m.) Review request for Plasma. Changes --- Another patch, which use custom config file. Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: http://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! File Attachments (updated) patch http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch another patch, use custom config file. http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/ --- (Updated Aug. 3, 2013, 3:36 a.m.) Review request for Plasma. Changes --- Add patch. Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: http://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! File Attachments (updated) patch http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 111849: custom first week for plasmaclock.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111849/ --- Review request for Plasma. Description --- In normal case, the first week is the first week in the year, but the teachers may want to custom the first week, for example, make the 8th week as the first week, then the 9th week will be the second week, and so on. Then the teacher can easily do their work as a custom teaching period! Diffs - Diff: http://git.reviewboard.kde.org/r/111849/diff/ Testing --- cd kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch The save configuration codes are not very beautiful, but it works fine! Thanks, Hu Zheng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
