Re: Review Request 114886: Port Time dataengine to QTimeZone

2014-01-06 Thread John Layt

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114886/#review46915
---

Ship it!


Looks good to me (haven't tested it though).

- John Layt


On Jan. 6, 2014, 3:07 p.m., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114886/
 ---
 
 (Updated Jan. 6, 2014, 3:07 p.m.)
 
 
 Review request for Plasma and John Layt.
 
 
 Repository: kde-workspace
 
 
 Description
 ---
 
 as $summary
 
 
 Diffs
 -
 
   plasma/generic/dataengines/time/timeengine.cpp 0321b0e 
   plasma/generic/dataengines/time/timesource.cpp 6651d56 
 
 Diff: https://git.reviewboard.kde.org/r/114886/diff/
 
 
 Testing
 ---
 
 Engine explorer shows correct values
 
 
 Thanks,
 
 Martin Klapetek
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114886: Port Time dataengine to QTimeZone

2014-01-06 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114886/#review46916
---


This review has been submitted with commit 
8038d91e2823864b2ba653cdd78b514c400344c2 by Martin Klapetek to branch master.

- Commit Hook


On Jan. 6, 2014, 3:07 p.m., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/114886/
 ---
 
 (Updated Jan. 6, 2014, 3:07 p.m.)
 
 
 Review request for Plasma and John Layt.
 
 
 Repository: kde-workspace
 
 
 Description
 ---
 
 as $summary
 
 
 Diffs
 -
 
   plasma/generic/dataengines/time/timeengine.cpp 0321b0e 
   plasma/generic/dataengines/time/timesource.cpp 6651d56 
 
 Diff: https://git.reviewboard.kde.org/r/114886/diff/
 
 
 Testing
 ---
 
 Engine explorer shows correct values
 
 
 Thanks,
 
 Martin Klapetek
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 114886: Port Time dataengine to QTimeZone

2014-01-06 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114886/
---

(Updated Jan. 6, 2014, 3:39 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and John Layt.


Repository: kde-workspace


Description
---

as $summary


Diffs
-

  plasma/generic/dataengines/time/timeengine.cpp 0321b0e 
  plasma/generic/dataengines/time/timesource.cpp 6651d56 

Diff: https://git.reviewboard.kde.org/r/114886/diff/


Testing
---

Engine explorer shows correct values


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel