Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-06-20 Thread Jonathan Riddell

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/
---

(Updated June 20, 2014, 9:32 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: oxygen


Description
---

do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
installs new cursor theme


Diffs
-

  CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 

Diff: https://git.reviewboard.kde.org/r/117856/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Jonathan Riddell

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/
---

Review request for Plasma.


Repository: oxygen


Description
---

do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
installs new cursor theme


Diffs
-

  CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 

Diff: https://git.reviewboard.kde.org/r/117856/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56846
---


hmm, not sure about that. is true that for a long timekde4 will stay installed, 
but i think it should sill work even when kde4 is not installed (especially 
because iirc cursors came from kde-workspace, that will be the first to not be 
installed anymore when the migration is going)

would it be possible for distributions to do the following?
have cursors in another package (different packages per repo should be 
something all distros can do?) and have the cursors package conflicting as an 
alternative package

- Marco Martin


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Jonathan Riddell


 On April 29, 2014, 10:22 a.m., Marco Martin wrote:
  hmm, not sure about that. is true that for a long timekde4 will stay 
  installed, but i think it should sill work even when kde4 is not installed 
  (especially because iirc cursors came from kde-workspace, that will be the 
  first to not be installed anymore when the migration is going)
  
  would it be possible for distributions to do the following?
  have cursors in another package (different packages per repo should be 
  something all distros can do?) and have the cursors package conflicting as 
  an alternative package

From an upstream view why would we ship something in Plasma releases that 
Plasma doesn't use?

Note similar issues in https://git.reviewboard.kde.org/r/117775/ for sound files


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56846
---


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Marco Martin


 On April 29, 2014, 10:22 a.m., Marco Martin wrote:
  hmm, not sure about that. is true that for a long timekde4 will stay 
  installed, but i think it should sill work even when kde4 is not installed 
  (especially because iirc cursors came from kde-workspace, that will be the 
  first to not be installed anymore when the migration is going)
  
  would it be possible for distributions to do the following?
  have cursors in another package (different packages per repo should be 
  something all distros can do?) and have the cursors package conflicting as 
  an alternative package
 
 Jonathan Riddell wrote:
 From an upstream view why would we ship something in Plasma releases that 
 Plasma doesn't use?
 
 Note similar issues in https://git.reviewboard.kde.org/r/117775/ for 
 sound files

won't be necessarly used in the first release, so they may probably be disabled 
for now. (but would be delaying the problem)

in the future the idea is to have themes that when selected can change plasma 
theme, cursors, widget styles, icons etc, and the oxygen one will be shipped by 
default and quick way to make it look like kde4


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56846
---


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56856
---


This doesn't make sense. We want oxygen cursors available.

Cursor themes are not a new concept.

- Aleix Pol Gonzalez


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Jonathan Riddell


 On April 29, 2014, 11:02 a.m., Aleix Pol Gonzalez wrote:
  This doesn't make sense. We want oxygen cursors available.
  
  Cursor themes are not a new concept.

It is not a question of themes, it is that two packages which install the same 
theme is a packaging problem.  In this case kde-workspace and oxygen install 
the same theme.  oxygen is a runtime component of KF5 based applications and 
should be co-installable with users runing Plasma 1 from kde-workspace


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56856
---


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 117856: do not install cursors, they clash with kde-runtime from KDE 4 and breeze now installs new cursor theme

2014-04-29 Thread Aleix Pol Gonzalez


 On April 29, 2014, 11:02 a.m., Aleix Pol Gonzalez wrote:
  This doesn't make sense. We want oxygen cursors available.
  
  Cursor themes are not a new concept.
 
 Jonathan Riddell wrote:
 It is not a question of themes, it is that two packages which install the 
 same theme is a packaging problem.  In this case kde-workspace and oxygen 
 install the same theme.  oxygen is a runtime component of KF5 based 
 applications and should be co-installable with users runing Plasma 1 from 
 kde-workspace


I agree with the premise, I don't agree with the conclusion.

You can't stop installing something only because you want to have the old 
version installed.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117856/#review56856
---


On April 29, 2014, 10:13 a.m., Jonathan Riddell wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117856/
 ---
 
 (Updated April 29, 2014, 10:13 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: oxygen
 
 
 Description
 ---
 
 do not install cursors, they clash with kde-runtime from KDE 4 and breeze now 
 installs new cursor theme
 
 
 Diffs
 -
 
   CMakeLists.txt 5521fe94c5f2dc2ce68af261081bc05c7f2ae571 
 
 Diff: https://git.reviewboard.kde.org/r/117856/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Jonathan Riddell
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel