Review Request 118351: [klipper] Port from KDialog to QDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118351: [klipper] Port from KDialog to QDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58577 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014, 12:59 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 12:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118351: [klipper] Port from KDialog to QDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58590 --- This review has been submitted with commit 3e96409fbb2ca2d5711505050dede93e599be49a by Martin Gräßlin to branch master. - Commit Hook On May 27, 2014, 12:59 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 12:59 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118351: [klipper] Port from KDialog to QDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 4:48 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118351: [klipper] Port from KDialog to QDialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58592 --- klipper/klipper.cpp https://git.reviewboard.kde.org/r/118351/#comment40781 is this a forgotten KDialog or on purpose ? - Ömer Fadıl Usta On May 27, 2014, 7:48 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 7:48 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118351: [klipper] Port from KDialog to QDialog
On May 27, 2014, 7:10 p.m., Ömer Fadıl Usta wrote: klipper/klipper.cpp, line 888 https://git.reviewboard.kde.org/r/118351/diff/1/?file=275367#file275367line888 is this a forgotten KDialog or on purpose ? it's on purpose. This is currently dead code (see the #ifdef HAVE_PRISON), thus I am not able to test it and refuse to do a blind port without testing ;-) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/#review58592 --- On May 27, 2014, 6:48 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118351/ --- (Updated May 27, 2014, 6:48 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDialog to QDialog Diffs - klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be Diff: https://git.reviewboard.kde.org/r/118351/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
