Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59065 --- if you want to enforce to use the same type on all, you can call qMaxdouble() and remove all the casts. - Aleix Pol Gonzalez On June 3, 2014, 1:48 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 1:48 a.m.) Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:06 p.m.) Review request for Plasma. Changes --- changed to qmaxdouble() Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs (updated) - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 src/declarativeimports/core/svgitem.cpp c0f30058f68bbfc78ef12477cb85c0159e43909c Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59081 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 3, 2014, 12:06 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:06 p.m.) Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 src/declarativeimports/core/svgitem.cpp c0f30058f68bbfc78ef12477cb85c0159e43909c Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59084 --- This review has been submitted with commit ce329f4402fcbe56f6a7ea6b75b26c7ff217160b by Harald Sitter to branch master. - Commit Hook On June 3, 2014, 12:06 p.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:06 p.m.) Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 src/declarativeimports/core/svgitem.cpp c0f30058f68bbfc78ef12477cb85c0159e43909c Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 12:37 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 src/declarativeimports/core/svgitem.cpp c0f30058f68bbfc78ef12477cb85c0159e43909c Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/#review59023 --- src/declarativeimports/core/framesvgitem.cpp https://git.reviewboard.kde.org/r/118487/#comment41073 double and isn't this redundant since 1.0 is double unless cast to something else? - Thomas Braxton On June 3, 2014, 1:36 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 1:36 a.m.) Review request for Plasma. Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118487: fix type issue with qreal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118487/ --- (Updated June 3, 2014, 1:48 a.m.) Review request for Plasma. Changes --- I'd consider the redundancy a boon really ;) Repository: plasma-framework Description --- floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures Diffs (updated) - src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1 Diff: https://git.reviewboard.kde.org/r/118487/diff/ Testing --- Thanks, Harald Sitter ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
