Review Request 119358: Fix position of ToolBox on second screen

2014-07-18 Thread Dan Vrátil

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119358/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Due to a typo, the offset of the ToolBox on first screen was applied to 
ToolBoxes on all other screens. This is only visible when panel inteferes with 
position of the ToolBox, i.e. when it's on the left or on the top.


Diffs
-

  shell/shellcorona.cpp 60de8ff 

Diff: https://git.reviewboard.kde.org/r/119358/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 119358: Fix position of ToolBox on second screen

2014-07-18 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119358/#review62660
---

Ship it!


Ship It!

- David Edmundson


On July 18, 2014, 4:35 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119358/
 ---
 
 (Updated July 18, 2014, 4:35 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Due to a typo, the offset of the ToolBox on first screen was applied to 
 ToolBoxes on all other screens. This is only visible when panel inteferes 
 with position of the ToolBox, i.e. when it's on the left or on the top.
 
 
 Diffs
 -
 
   shell/shellcorona.cpp 60de8ff 
 
 Diff: https://git.reviewboard.kde.org/r/119358/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 119358: Fix position of ToolBox on second screen

2014-07-18 Thread David Edmundson


 On July 18, 2014, 4:42 p.m., David Edmundson wrote:
  Ship It!

in the 5.0 branch too please


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119358/#review62660
---


On July 18, 2014, 4:35 p.m., Dan Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/119358/
 ---
 
 (Updated July 18, 2014, 4:35 p.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Due to a typo, the offset of the ToolBox on first screen was applied to 
 ToolBoxes on all other screens. This is only visible when panel inteferes 
 with position of the ToolBox, i.e. when it's on the left or on the top.
 
 
 Diffs
 -
 
   shell/shellcorona.cpp 60de8ff 
 
 Diff: https://git.reviewboard.kde.org/r/119358/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Vrátil
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 119358: Fix position of ToolBox on second screen

2014-07-18 Thread Dan Vrátil

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119358/
---

(Updated July 18, 2014, 6:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Due to a typo, the offset of the ToolBox on first screen was applied to 
ToolBoxes on all other screens. This is only visible when panel inteferes with 
position of the ToolBox, i.e. when it's on the left or on the top.


Diffs
-

  shell/shellcorona.cpp 60de8ff 

Diff: https://git.reviewboard.kde.org/r/119358/diff/


Testing
---


Thanks,

Dan Vrátil

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel