Re: Review Request 119515: Support per-activity favourites for Kickoff

2015-12-15 Thread Ivan Čukić 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---

(Updated Dec. 15, 2015, 11:09 a.m.)


Status
--

This change has been discarded.


Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.


Repository: plasma-desktop


Description
---

This patch adds the support to have favourites linked to activities.

It uses org.kde.activities.ResourceModel to show favorites.

It supports:
 - adding a favourite to all activities (the previous behaviour)
 - adding a favourite to the current activity
 - moving a favourite between 'all activities' and 'current activity' modes (it 
does not affect non-current activities)
 - drag-and-drop reordering of items (like the previous one)
 - sorting A-Z, Z-A (like the previous one)
 - transitions previously defined favourites to the new system*

Context menu item captions could maybe use some improvement.

Screenshot available at: 
http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments

* this can also be used for defining the default favourites in a global 
kickoffrc file - instead of them being hard-coded like they currently are.


Diffs
-

  applets/kickoff/CMakeLists.txt 28e7029 
  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 
  applets/kickoff/core/kickoffplugin.cpp f549981 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp db2adab 
  applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
  applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 

Diff: https://git.reviewboard.kde.org/r/119515/diff/


Testing
---

Yes


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-10-09 Thread Marco Martin 
Hi all,

since now 5.1 is branched, i would like to revert commit c8adae02c993a
Revert "Support per-activity favourites in Kickoff"

to have it again in master and start to iron out possible problems in master 
in the meantime

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites for Kickoff

2014-08-09 Thread Ivan Čukić 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---

(Updated Aug. 9, 2014, 8:48 a.m.)


Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.


Summary (updated)
-

Support per-activity favourites for Kickoff


Repository: plasma-desktop


Description
---

This patch adds the support to have favourites linked to activities.

It uses org.kde.activities.ResourceModel to show favorites.

It supports:
 - adding a favourite to all activities (the previous behaviour)
 - adding a favourite to the current activity
 - moving a favourite between 'all activities' and 'current activity' modes (it 
does not affect non-current activities)
 - drag-and-drop reordering of items (like the previous one)
 - sorting A-Z, Z-A (like the previous one)
 - transitions previously defined favourites to the new system*

Context menu item captions could maybe use some improvement.

Screenshot available at: 
http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments

* this can also be used for defining the default favourites in a global 
kickoffrc file - instead of them being hard-coded like they currently are.


Diffs
-

  applets/kickoff/CMakeLists.txt 28e7029 
  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 
  applets/kickoff/core/kickoffplugin.cpp f549981 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp db2adab 
  applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
  applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 

Diff: https://git.reviewboard.kde.org/r/119515/diff/


Testing
---

Yes


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-29 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63406
---



applets/kickoff/core/krunnermodel.cpp


We generally don't want any new code using deprecated classes, such as 
KUrl. Can you change that?


- Sebastian Kügler


On July 28, 2014, 5:50 p.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 5:50 p.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---

(Updated July 28, 2014, 5:50 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.


Repository: plasma-desktop


Description
---

This patch adds the support to have favourites linked to activities.

It uses org.kde.activities.ResourceModel to show favorites.

It supports:
 - adding a favourite to all activities (the previous behaviour)
 - adding a favourite to the current activity
 - moving a favourite between 'all activities' and 'current activity' modes (it 
does not affect non-current activities)
 - drag-and-drop reordering of items (like the previous one)
 - sorting A-Z, Z-A (like the previous one)
 - transitions previously defined favourites to the new system*

Context menu item captions could maybe use some improvement.

Screenshot available at: 
http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments

* this can also be used for defining the default favourites in a global 
kickoffrc file - instead of them being hard-coded like they currently are.


Diffs
-

  applets/kickoff/CMakeLists.txt 28e7029 
  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 
  applets/kickoff/core/kickoffplugin.cpp f549981 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp db2adab 
  applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
  applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 

Diff: https://git.reviewboard.kde.org/r/119515/diff/


Testing
---

Yes


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić 


> On July 28, 2014, 5:31 p.m., Thomas Braxton wrote:
> > applets/kickoff/package/contents/ui/ContextMenu.qml, line 62
> > 
> >
> > addToGlobalFavorites sounds better

Agreed.


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63349
---


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Thomas Braxton 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63349
---



applets/kickoff/package/contents/ui/ContextMenu.qml


addToGlobalFavorites sounds better



applets/kickoff/package/contents/ui/ContextMenu.qml


same here
addToActivityFavorites


- Thomas Braxton


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63347
---

Ship it!


for kickoff, for what i'm concerned is good to go

- Marco Martin


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić 


> On July 28, 2014, 12:03 p.m., Marco Martin wrote:
> > +1 from me, would like toknow from Eike if this provides all is needed for 
> > use cases outside kickoff
> 
> Eike Hein wrote:
> Kicker doesn't use Kickoff's models, i.e. activity support has to be 
> implemented in Kicker's own favorites model.

So, what is the decision for the kickoff patch?


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63321
---


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Eike Hein 


> On July 28, 2014, 12:03 p.m., Marco Martin wrote:
> > +1 from me, would like toknow from Eike if this provides all is needed for 
> > use cases outside kickoff

Kicker doesn't use Kickoff's models, i.e. activity support has to be 
implemented in Kicker's own favorites model.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63321
---


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63321
---


+1 from me, would like toknow from Eike if this provides all is needed for use 
cases outside kickoff

- Marco Martin


On July 28, 2014, 11:49 a.m., Ivan Čukić wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119515/
> ---
> 
> (Updated July 28, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This patch adds the support to have favourites linked to activities.
> 
> It uses org.kde.activities.ResourceModel to show favorites.
> 
> It supports:
>  - adding a favourite to all activities (the previous behaviour)
>  - adding a favourite to the current activity
>  - moving a favourite between 'all activities' and 'current activity' modes 
> (it does not affect non-current activities)
>  - drag-and-drop reordering of items (like the previous one)
>  - sorting A-Z, Z-A (like the previous one)
>  - transitions previously defined favourites to the new system*
> 
> Context menu item captions could maybe use some improvement.
> 
> Screenshot available at: 
> http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments
> 
> * this can also be used for defining the default favourites in a global 
> kickoffrc file - instead of them being hard-coded like they currently are.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/CMakeLists.txt 28e7029 
>   applets/kickoff/core/favoritesmodel.h 27a0626 
>   applets/kickoff/core/favoritesmodel.cpp f05588b 
>   applets/kickoff/core/kickoffplugin.cpp f549981 
>   applets/kickoff/core/krunnermodel.h 3916829 
>   applets/kickoff/core/krunnermodel.cpp db2adab 
>   applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
>   applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 
> 
> Diff: https://git.reviewboard.kde.org/r/119515/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---

Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.


Repository: plasma-desktop


Description
---

This patch adds the support to have favourites linked to activities.

It uses org.kde.activities.ResourceModel to show favorites.

It supports:
 - adding a favourite to all activities (the previous behaviour)
 - adding a favourite to the current activity
 - moving a favourite between 'all activities' and 'current activity' modes (it 
does not affect non-current activities)
 - drag-and-drop reordering of items (like the previous one)
 - sorting A-Z, Z-A (like the previous one)
 - transitions previously defined favourites to the new system*

Context menu item captions could maybe use some improvement.

Screenshot available at: 
http://ivan.fomentgroup.org/blog/2014/07/27/per-activity-favourites-in-kickoff/#/comments

* this can also be used for defining the default favourites in a global 
kickoffrc file - instead of them being hard-coded like they currently are.


Diffs
-

  applets/kickoff/CMakeLists.txt 28e7029 
  applets/kickoff/core/favoritesmodel.h 27a0626 
  applets/kickoff/core/favoritesmodel.cpp f05588b 
  applets/kickoff/core/kickoffplugin.cpp f549981 
  applets/kickoff/core/krunnermodel.h 3916829 
  applets/kickoff/core/krunnermodel.cpp db2adab 
  applets/kickoff/package/contents/ui/ContextMenu.qml 6a67874 
  applets/kickoff/package/contents/ui/FavoritesView.qml 6c2d5d4 
  applets/kickoff/package/contents/ui/FullRepresentation.qml 6291b7c 

Diff: https://git.reviewboard.kde.org/r/119515/diff/


Testing
---

Yes


Thanks,

Ivan Čukić

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel