Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/#review64426 --- applets/kickoff/package/contents/ui/KickoffButton.qml https://git.reviewboard.kde.org/r/119748/#comment45017 anchors.margins sets all the margins. And if you're at it, can you migrate that to units.smallSpacing (or so), ie. no hardcoded pixels? applets/kickoff/package/contents/ui/KickoffButton.qml https://git.reviewboard.kde.org/r/119748/#comment45018 Superfluous semicolon - Kai Uwe Broulik On Aug. 13, 2014, 12:37 vorm., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 12:37 vorm.) Review request for Plasma. Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 10:39 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs (updated) - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 12:54 p.m.) Review request for Plasma. Bugs: 336705 https://bugs.kde.org/show_bug.cgi?id=336705 Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/#review64456 --- Ship it! Ship It! - Sebastian Kügler On aug 13, 2014, 10:54 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated aug 13, 2014, 10:54 a.m.) Review request for Plasma. Bugs: 336705 https://bugs.kde.org/show_bug.cgi?id=336705 Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 1:07 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Bugs: 336705 https://bugs.kde.org/show_bug.cgi?id=336705 Repository: plasma-desktop Description --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119748: Properly align KickoffButtons to center when in vertical mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- Review request for Plasma. Repository: plasma-desktop Description --- The labels in Kickoff are misaligned when Kickoff is in vertical mode (see the first screenshot). This patch fixes it by making sure the KickoffButton is always as wide as the parent container, even when the label string is shorter, so that the text is always centered. Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:35 a.m.) Review request for Plasma. Changes --- Now the icons and the labels are both horizontally and vertically centered in both vertical and horizontal mode \o/ (see the last screenshot) Repository: plasma-desktop Description --- The first and the last labels in Kickoff are misaligned (see the first screenshot) for some reason - even though the Label correctly fills the entire parent width, the test is still aligned to left. To workaround this issue, this patch wraps the Label into an Item - now the labels are correctly aligned in the center . I don't have any explanation for why does this happen, nor do I understand why wrapping the stuff in Item fixes the problem, so please don't ask (but please explain it to me if you happen to know) :-). Diffs (updated) - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments (updated) Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119748: Properly align KickoffButtons to center
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ --- (Updated Aug. 13, 2014, 2:37 a.m.) Review request for Plasma. Repository: plasma-desktop Description (updated) --- The icons and labels are misaligned (both vertically and horizontally) in Kickoff (see the first screenshow) - this patch makes sure that the content of the tab is always centered in both vertical and horizontal mode (see the last screenshot). Diffs - applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing --- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments (updated) Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel