Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:39 p.m.) Review request for Plasma. Changes --- Lukas Tinkl found a nice way to get Caps Lock status and changes from the KeyState DataEngine, so the patch now makes use of the DataEngine and removes the X11-dependent CapsLock status detection from greeterapp.cpp Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65208 --- lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45574 Does that work? Shouldn't it be dataChanged() ? - Kai Uwe Broulik On Aug. 25, 2014, 1:39 nachm., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 1:39 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 --- Ship it! Nice lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45576 does it not work to do visible: keystateSource.data[Caps Lock][Locked] and then get rid of the function? - David Edmundson On Aug. 25, 2014, 1:39 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 1:39 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 2:11 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 25, 2014, 2:04 p.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 178 https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line178 Does that work? Shouldn't it be dataChanged() ? both work, this calls the slot, yours would emit the signal which would call the slot. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65208 --- On Aug. 25, 2014, 1:39 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 1:39 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 25, 2014, 4:11 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 167 https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line167 does it not work to do visible: keystateSource.data[Caps Lock][Locked] and then get rid of the function? Yep, that works perfectly. - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 --- On Aug. 25, 2014, 4:11 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 4:11 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65237 --- lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45584 What was the point of this layout, there's only one item in it? - David Edmundson On Aug. 25, 2014, 3:10 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 25, 2014, 5:25 p.m., David Edmundson wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 119 https://git.reviewboard.kde.org/r/119797/diff/5/?file=307555#file307555line119 What was the point of this layout, there's only one item in it? nevermind, I got confused. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65237 --- On Aug. 25, 2014, 3:10 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 25, 2014, 3:10 p.m.) Review request for Plasma and Andrew Lake. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - ksmserver/screenlocker/greeter/greeterapp.cpp bb8a2bd lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, lines 166-167 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line166 So you tell it to be centered horizontally, and wrap, but a maximum of one line is allowed? This will have no effect whatsoever since the label will just grow outside horizontally because it has no width/side anchors set. Just copy-pasted from the notificationLabel above :-) On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 32 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line32 You generally don't need semicolons after QML properties Sorry, habit of a C++ programmer - punch semicolon after every line :) On Aug. 15, 2014, 10:34 a.m., Kai Uwe Broulik wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 63 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line63 units.largeSpacing * 15 Nonetheless, that looks wrong to me, don't we have gridUnit for stuff like that? This actually represents the height of the actual content block - I'm not sure we can/want to use some generic value for that. I think in ideal case the height of the element should be based on total height of the elements it contains - I'm not sure why this is not the case but I'll try to do it that way first. - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64587 --- On Aug. 15, 2014, 12:25 a.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 15, 2014, 12:25 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 18, 2014, 8:55 vorm., Martin Klapetek wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 162 https://git.reviewboard.kde.org/r/119797/diff/2/?file=305636#file305636line162 Thinking about the label... What if we'd remove the Warning: part and either just leave it like that or make the font red? My reasoning being that a text suddenly appearing is enough to notice and therefore the warning part is not necessary. If the purpose of the Warning is to catch user's attention, this could be done as well by the red color with the advantage of less words needed to read and red color generally meaning warning/attention. Oh and the ! at the end should go, somewhere there is a guideline saying don't make screaming interfaces ;) Yes! Those Hint:, Warning:, Note: etc always bugged me. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64713 --- On Aug. 14, 2014, 10:25 nachm., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 14, 2014, 10:25 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:19 p.m.) Review request for Plasma. Changes --- Fix review comments Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45295 I don't see who is setting the value for capsLockOn, did I miss something? Also this could be an alias to the label visible property. - Aleix Pol Gonzalez On Aug. 18, 2014, 2:21 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 2:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 18, 2014, 4:24 p.m., Aleix Pol Gonzalez wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 32 https://git.reviewboard.kde.org/r/119797/diff/4/?file=306152#file306152line32 I don't see who is setting the value for capsLockOn, did I miss something? Also this could be an alias to the label visible property. This property is set by UnlockApp in ksmserver/screenlocker/greeter/greeterapp.cpp on l383 - the code for capslock state detection has already been there (brough in from KDE 4), we were just not making use of the property in QML. Should I add a comment where this is comming from? - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- On Aug. 18, 2014, 4:21 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 4:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
On Aug. 18, 2014, 2:24 p.m., Aleix Pol Gonzalez wrote: lookandfeel/contents/lockscreen/LockScreen.qml, line 32 https://git.reviewboard.kde.org/r/119797/diff/4/?file=306152#file306152line32 I don't see who is setting the value for capsLockOn, did I miss something? Also this could be an alias to the label visible property. Dan Vrátil wrote: This property is set by UnlockApp in ksmserver/screenlocker/greeter/greeterapp.cpp on l383 - the code for capslock state detection has already been there (brough in from KDE 4), we were just not making use of the property in QML. Should I add a comment where this is comming from? Well, this code is being used by the SDDM theme as well, so making it into a proper QML component would make sense, I'd say. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64758 --- On Aug. 18, 2014, 2:21 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 18, 2014, 2:21 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64587 --- lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45140 You generally don't need semicolons after QML properties lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45139 units.largeSpacing * 15 Nonetheless, that looks wrong to me, don't we have gridUnit for stuff like that? lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45138 Swap those, ie. empty line below lookandfeel/contents/lockscreen/LockScreen.qml https://git.reviewboard.kde.org/r/119797/#comment45137 So you tell it to be centered horizontally, and wrap, but a maximum of one line is allowed? This will have no effect whatsoever since the label will just grow outside horizontally because it has no width/side anchors set. - Kai Uwe Broulik On Aug. 14, 2014, 10:25 nachm., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 14, 2014, 10:25 nachm.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/#review64580 --- lookandfeel/contents/components/UserSelect.qml https://git.reviewboard.kde.org/r/119797/#comment45130 setting a top anchor a bottom anchor and a height means one is ignored and therefore one of these lines should be deleted - David Edmundson On Aug. 14, 2014, 10:09 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 14, 2014, 10:09 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs - lookandfeel/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119797: Show warning in lockscreen when capslock is enabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119797/ --- (Updated Aug. 15, 2014, 12:25 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- This will show a warning when capslock is enabled, like it used to in KDE 4 screen locker. Diffs (updated) - lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 lookandfeel/contents/components/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
